Fix failure in test_settings_bluetooth.py

RESOLVED FIXED

Status

Firefox OS
Gaia::UI Tests
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Martijn Wargers (dead), Assigned: Martijn Wargers (dead))

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
I was seeing this failure, while testing the pull request in bug 1176527.
http://mxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/tests/functional/settings/test_settings_bluetooth.py
Apparently, this has now also switched over to the Bluetooth V2 Api, recently.
Created attachment 8631827 [details] [review]
[gaia] mwargers:1182284 > mozilla-b2g:master
(Assignee)

Comment 2

3 years ago
Comment on attachment 8631827 [details] [review]
[gaia] mwargers:1182284 > mozilla-b2g:master

The pull request from bug 1176527 is also visible in this pull request (not sure why), but you can look at: https://github.com/mwargers/gaia/commit/cff593b5d656719eddef55fd77001f44227ce633
I removed the 'bluetooth.visible' setting, because that apparently doesn't happen in the Bluetooth V2 API.
Attachment #8631827 - Flags: review?(npark)
Attachment #8631827 - Flags: review?(jlorenzo)
Comment on attachment 8631827 [details] [review]
[gaia] mwargers:1182284 > mozilla-b2g:master

based on what I learned so far about bluetooth since yesterday, it seems okay to me in terms of python code itself.
Attachment #8631827 - Flags: review?(npark) → review+
Comment on attachment 8631827 [details] [review]
[gaia] mwargers:1182284 > mozilla-b2g:master

LGTM
Attachment #8631827 - Flags: review?(jlorenzo) → review+
Depends on: 1176527
(Assignee)

Comment 5

3 years ago
Merged: https://github.com/mozilla-b2g/gaia/commit/c4c2164c99310fe12ffcf801f304adfee806162c
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.