1182290 - Clearing Private Data on iPads crashes

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Bryan Munar (:bkmunar)]

Clear private data on an iPad. Lo and behold el crasho.

Comment 1

[Richard Newman [:rnewman]]

Stack please!

Comment 2

[Bryan Munar (:bkmunar)]

2015-07-09 14:13:16.855 Client[4658:196933] *** Terminating app due to uncaught exception 'NSGenericException', reason: 'Your application has presented a UIAlertController (<UIAlertController: 0x7fb52b456490>) of style UIAlertControllerStyleActionSheet. The modalPresentationStyle of a UIAlertController with this style is UIModalPresentationPopover. You must provide location information for this popover through the alert controller's popoverPresentationController. You must provide either a sourceView and sourceRect or a barButtonItem.  If this information is not known when you present the alert controller, you may provide it in the UIPopoverPresentationControllerDelegate method -prepareForPopoverPresentation.'
*** First throw call stack:
(
	0   CoreFoundation                      0x00000001116e1c65 __exceptionPreprocess + 165
	1   libobjc.A.dylib                     0x0000000110c09bb7 objc_exception_throw + 45
	2   UIKit                               0x0000000112acc03a -[UIPopoverPresentationController presentationTransitionWillBegin] + 2650
	3   UIKit                               0x00000001124c7d39 __71-[UIPresentationController _initViewHierarchyForPresentationSuperview:]_block_invoke + 1305
	4   UIKit                               0x00000001124c6380 __56-[UIPresentationController runTransitionForCurrentState]_block_invoke + 189
	5   UIKit                               0x00000001123dc5ec _applyBlockToCFArrayCopiedToStack + 314
	6   UIKit                               0x00000001123dc466 _afterCACommitHandler + 533
	7   CoreFoundation                      0x0000000111614ca7 __CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION__ + 23
	8   CoreFoundation                      0x0000000111614c00 __CFRunLoopDoObservers + 368
	9   CoreFoundation                      0x000000011160aa33 __CFRunLoopRun + 1123
	10  CoreFoundation                      0x000000011160a366 CFRunLoopRunSpecific + 470
	11  GraphicsServices                    0x0000000115120a3e GSEventRunModal + 161
	12  UIKit                               0x00000001123b88c0 UIApplicationMain + 1282
	13  Client                              0x000000010f312445 main + 997
	14  libdyld.dylib                       0x0000000117fc1145 start + 1
)
libc++abi.dylib: terminating with uncaught exception of type NSException

Comment 3

[Richard Newman [:rnewman]]

Thanks. Let's get an assignee.

Comment 4

[Bryan Munar (:bkmunar)]

I think I know the problem and will find a fix for it

Comment 5

[Bryan Munar (:bkmunar)]

Fixed! iPads don't like UIAlertControllerStyle.ActionSheet, so I just made the "Clear Everything" dialogue be a UIAlertControllerStyle.Alert. It makes the dialogue look different for phones (instead of sliding up and having the options stacked vertically, it fades into the center with the options displayed horizontally), but it's nice and consistent. Also, BNicholz says it's iOS convention to put destructive actions like "clear" on the left versus the right (we have it switched right now). Will probably file a follow up bug to change that? Thoughts?

Comment 6

[Bryan Munar (:bkmunar)]

Attachment: PR

Because you implemented settings!

Comment 7

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8632364 [details] [review]
PR

If it works for you, it works for me.  (wesj did the actual work here, IIRC.)

File bnicholson's follow-up, please, and can you audit the code to make sure we never use this bad combination of flags?

Comment 9

[Aaron Train [:aaronmt]]

Note: This missed Build #24