Open Bug 1182303 Opened 6 years ago Updated 6 years ago

Firefox iOS susceptible to infinite alert loops

Categories

(Firefox for iOS :: Browser, defect)

All
iOS
defect
Not set
normal

Tracking

()

Tracking Status
fxios + ---

People

(Reporter: wesj, Unassigned)

References

()

Details

(Whiteboard: [parity=fxandroid][nicetohave])

Attachments

(4 files)

I have no idea how i got to 'ios-security99.com' while trying to type 'twitter.com', but the page (maliciously) shows an alert dialog in a constant loop. We should detect loops like that and prevent the page showing more dialogs.
Whiteboard: [parity=fxandroid]
tracking-fxios: --- → ?
Assignee: nobody → bmunar
Attachment #8650161 - Flags: ui-review?(randersen)
Attachment #8650161 - Flags: review?(bnicholson)
Comment on attachment 8650161 [details] [review]
PR - LAND AFTER v1 RELEASE!

Looks OK to me with some cleanup.
Attachment #8650161 - Flags: review?(bnicholson) → review+
I'll fix and land this.
Assignee: brymunar → bnicholson
Status: NEW → ASSIGNED
Comment on attachment 8650161 [details] [review]
PR - LAND AFTER v1 RELEASE!

Brian,

Two things:
1) change the black line to the same light grey as the other
2) change the switch active color to the same orange we use in Settings
Comment on attachment 8650161 [details] [review]
PR - LAND AFTER v1 RELEASE!

This isn't actually ready to land yet. Testing on a prompt dialog, we get this: https://www.dropbox.com/s/28sle4l5l8wxshk/Screenshot%202015-08-27%2011.57.15.png?dl=0

We need to move the disable prompt to be under the the text field, which we can't do simply by injecting "\n"s as a whitespace hack (which this PR currently does). That means we'll need to fidget around with the existing dialog layout or create our own dialog from scratch. Note that Apple recommends against the former: "The UIAlertController class is intended to be used as-is and does not support subclassing. The view hierarchy for this class is private and must not be modified." [1]

[1] https://developer.apple.com/library/ios/documentation/UIKit/Reference/UIAlertController_class/
Attachment #8650161 - Flags: review+ → review-
Since this will take some more work, going to re-nom this...I have a feeling we have higher priority items for v1.0.x/1.1.
Assignee: bnicholson → nobody
Status: ASSIGNED → NEW
Whiteboard: [parity=fxandroid] → [parity=fxandroid][nice-to-have]
Whiteboard: [parity=fxandroid][nice-to-have] → [parity=fxandroid][nicetohave]
Whiteboard: [parity=fxandroid][nicetohave] → [parity=fxandroid][nicetohave][needs strings]
Strings only.
Assignee: nobody → bnicholson
Status: NEW → ASSIGNED
Attachment #8663100 - Flags: review?(sarentz)
Attachment #8663100 - Flags: review?(sarentz) → review+
Landed strings: https://github.com/mozilla/firefox-ios/commit/933b7d5eb513388b0b52558be4ccc9bf96484f14
Whiteboard: [parity=fxandroid][nicetohave][needs strings] → [parity=fxandroid][nicetohave]
Assignee: bnicholson → nobody
Status: ASSIGNED → NEW
Rank: 3
Component: General → Browser
Hardware: Other → All
Duplicate of this bug: 1237323
You need to log in before you can comment on or make changes to this bug.