Please report any other irregularities here.
Created attachment 8631949 [details] [diff] [review] 0008-Handle-all-zero-_BitScanReverse.patch MSVC code analysis complains about this. https://msdn.microsoft.com/en-us/library/fbxyd7zd.aspx _BitScanReverse doesn't modify `*pIndex` is the input is all zeros. We need to either test for this before-hand, or test the retval from _BitScanReverse, which is zero if input is zero. (non-zero otherwise)
Attachment #8631949 - Flags: review?(jwalden+bmo)
Attachment #8631949 - Flags: review?(jwalden+bmo) → review+
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.