Closed
Bug 1182373
Opened 10 years ago
Closed 10 years ago
Constant-folding in the tag in a tagged template can change semantics
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla42
| Tracking | Status | |
|---|---|---|
| firefox42 | --- | fixed |
People
(Reporter: Waldo, Assigned: Waldo)
Details
Attachments
(1 file)
|
2.54 KB,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
The tagged-template version of bug 537673. Yes, really.
|
Assignee | |
Comment 1•10 years ago
|
||
The removal of PNK_NEW is a driveby change that I argue is entirely correct -- or at least I can't think of a reason why it isn't, as the callee component of a new-expression is fully evaluated before the call is made (by spec), and the |new| obviously gets its own |this|. Additionally, this patch passes jstests and jit-tests locally, which says we have no test that breaks with this change made. No tests that bust without code, that code isn't needed.
Attachment #8631959 -
Flags: review?(jorendorff)
|
||
Updated•10 years ago
|
Attachment #8631959 -
Flags: review?(jorendorff) → review+
|
|
||
Comment 3•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•