1182406 - Serialize L20n resources into an object

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::L10n, defect)

Description

[Staś Małolepszy :stas]

A follow-up to bug 1169361:  the serialized JSON for entries should be an object and not an array with an object.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] stasm:1182406-serialize-l20n-to-object > mozilla-b2g:master

Comment 2

[Staś Małolepszy :stas]

Comment on attachment 8632024 [details] [review]
[gaia] stasm:1182406-serialize-l20n-to-object > mozilla-b2g:master

https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=5e106e06030cd91a7bc718d01ad44769f837fef0

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

Can you use r? on a PR against l20n.js? The webpack output is so mingled that reviewing this is close to impossible.

Comment 4

[Staś Małolepszy :stas]

Attachment: Pull request against l20n.js

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8632266 [details] [review]
Pull request against l20n.js

Thanks!

I left two minor nits that you may want to consider.

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8632024 [details] [review]
[gaia] stasm:1182406-serialize-l20n-to-object > mozilla-b2g:master

Damn, webpack is making the history of build/l10n/l20n.js worthless. Is there a way to prevent it from mingling module order on each build?

Comment 7

[Staś Małolepszy :stas]

I don't suppose there is.  I did like your suggestion of splitting l20n into separate files in build/l10n though.

I'll wait for https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=5a2c517584cd4121d29acf6225f0718a0faf341f to pass and land.

Comment 8

[Zibi Braniecki [:zbraniecki][:gandalf]]

(In reply to Staś Małolepszy :stas from comment #7)
> I don't suppose there is.  I did like your suggestion of splitting l20n into
> separate files in build/l10n though.

Cool. Let's talk about this next week. I like this option as well more than the webpack.

Comment 9

[Staś Małolepszy :stas]

https://github.com/mozilla-b2g/gaia/commit/2fc6289cd0afdcbf6370e06353459bba250ff3c4
https://github.com/l20n/l20n.js/commit/1d3952d55ae08a51e357831a03f821c99fbbfe80

Comment 10

[Zibi Braniecki [:zbraniecki][:gandalf]]

confirming that it fixes the bug