Closed
Bug 1182465
Opened 9 years ago
Closed 9 years ago
Remove substitution of 'engine' for 'InnoDB' in the template schema
Categories
(Tree Management :: Treeherder, defect, P3)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: emorley)
References
Details
Attachments
(1 file)
Once bug 1182455 lands, we can stop the redundant substitution of 'engine' for 'InnoDB' in the template schema, given that engine is now always InnoDB in create_db(): https://github.com/mozilla/treeherder/blob/9371347bc238dd4c83658fc363949a3c5dce86ff/treeherder/model/models.py#L335
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8632440 -
Flags: review?(cdawson)
Comment 2•9 years ago
|
||
Comment on attachment 8632440 [details] [review] Remove substitution of 'engine' in the template schema That's simple enough. :)
Attachment #8632440 -
Flags: review?(cdawson) → review+
Comment 3•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/811ec9b90bfe318103b742980e57adc6b7b9a5ee Bug 1182465 - Remove substitution of 'engine' in the template schema Since after bug 1182455, engine is now guaranteed to always the same for all projects, so we can just specify it in the schema directly. As an added bonus, the templates are now valid SQL.
Assignee | ||
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•