Closed Bug 1182484 Opened 5 years ago Closed 5 years ago

[Contacts][NGA] Move curtain from <iframe> to a panel in 'Matching'

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(b2g-master fixed)

RESOLVED FIXED
FxOS-S3 (24Jul)
Tracking Status
b2g-master --- fixed

People

(Reporter: borjasalguero, Assigned: borjasalguero)

References

Details

(Whiteboard: [NG Gaia Contacts][patch])

Attachments

(1 file)

We want to have everything as webby as possible, and curtain is a complex structure just to show just a message or a progress bar.

With NGA, we want to load the .html needed using window.open instead of multiple <iframes> in the current document. In order to be align with UX, some of the .html we use (import.html, matching_contacts.html...) need a panel to show a message, a confirm or a progress bar. This is called 'curtain', and currently is a separate <iframe>. We are going to move all this logic to a Panel, so everything will be executed within the .html opened by window.open. The less 'magic' we have, the better performance we will achieve.
Blocks: 1169191
Whiteboard: [NG Gaia Contacts]
Assignee: nobody → borja.bugzilla
Status: NEW → ASSIGNED
Comment on attachment 8632118 [details] [review]
[gaia] borjasalguero:curtain > mozilla-b2g:master

This is the first step in order to get a lighter version of the import, matcher... html. r?
Attachment #8632118 - Flags: review?(francisco)
Attachment #8632118 - Flags: review?(b.mcb)
Whiteboard: [NG Gaia Contacts] → [NG Gaia Contacts][patch]
Target Milestone: --- → FxOS-S3 (24Jul)
Comment on attachment 8632118 [details] [review]
[gaia] borjasalguero:curtain > mozilla-b2g:master

Fernando, could you take a look to FTU? Thanks!
Attachment #8632118 - Flags: review?(fernando.campo)
Comment on attachment 8632118 [details] [review]
[gaia] borjasalguero:curtain > mozilla-b2g:master

Just a comment in github but it has already been solved =)

Works fine!

Thanks Borja!
Attachment #8632118 - Flags: review?(b.mcb) → review+
No longer blocks: 1181996
Comment on attachment 8632118 [details] [review]
[gaia] borjasalguero:curtain > mozilla-b2g:master

Sadly it's not working on the FTU. after all the oauth process goes ok, we should get the contact list back on the <extensions> iframe, but everything gets hidden instead. After the first try (where you need to do all the oauth), every other time you click on 'gmail', nothing seem to happen visually (although <extensions> gets the proper src="/shared/pages/import/import.html?ftu=1&service=gmail")
Attachment #8632118 - Flags: review?(fernando.campo)
Comment on attachment 8632118 [details] [review]
[gaia] borjasalguero:curtain > mozilla-b2g:master

Little tiny nits, but definitely r+

Thanks!
Attachment #8632118 - Flags: review?(francisco) → review+
Summary: [Contacts][NGA] Move curtain from <iframe> to a panel → [Contacts][NGA] Move curtain from <iframe> to a panel in 'Matching'
I've updated the code so now we are going to tackle curtain *just* in 'matching'. Let's try to fix import (affecting to FTU & Contacts) in https://bugzilla.mozilla.org/show_bug.cgi?id=1183561.
See Also: → 1183561
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Borja, this is another contacts patch that landed without l10n review which is using deprecated API.

Can you look at https://developer.mozilla.org/en-US/Firefox_OS/Developing_Gaia/localization_code_best_practices, fix this, stop using mozL10n.get in your future patches please?
Flags: needinfo?(borja.bugzilla)
Thanks Zibi, we have created a follow-up bug (Bug 1184483) to remove the uses of mozL10n.get in the patch
Depends on: 1184483
Blocks: 1184483
No longer depends on: 1184483
Flags: needinfo?(borja.bugzilla)
You need to log in before you can comment on or make changes to this bug.