1182533 - Eliminate race conditions in the ico-bmp-corrupted tests

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Seth Fowler [:seth] [:s2h]]

We've had lots of intermittent orange issues with the ico-bmp-corrupted tests, and now bug 1117607 is turning those into permaoranges. That's actually a good thing, as it makes it easier to debug them.

It turns out that the source of the problem is that our rendering is nondeterministic when an error is detected in the image data of an image (as opposed to the header).

I've filed bug 1182531 about fixing the underlying problem, but I'd rather that issue not block bug 1117607. So in this bug, we'll:

- Modify ico-bmp-corrupted/wrapper.html to sync decode the corrupt images *before* loading them into the final <img> element, which eliminates the nondeterminism.

- Annotate the ico-bmp-corrupted tests to make it clear which ones detect the error in the header and which ones detect the error in the image data. That should make it easier to fix bug 1182531 later.

Comment 1

[Seth Fowler [:seth] [:s2h]]

Attachment: Sync decode ico-bmp-corrupted images before loading them in the <img> element

Here's the patch. This eliminates the nondeterminism I was seeing in bug
1117607.

Comment 2

[Seth Fowler [:seth] [:s2h]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/567ba1606694

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/567ba1606694