1182541 - Resolve the "m" accesskey conflict in the privacy panel

Status: RESOLVED FIXED

(Firefox :: General, defect, P1)

Description

[Panos Astithas (he/him) [:past] (please ni?)]

In bug 1175920 I have accidentally introduced another checkbox with the "m" accesskey. This bug is for fixing it.

Comment 1

[Marco Mucci [:MarcoM]]

Hi Panos, will this bug require QA verification?

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

Verification is possible but also trivial and I'm not sure what we prefer to do in these cases. We could definitely skip verification if QA is overloaded.

Comment 3

[Marco Mucci [:MarcoM]]

(In reply to Panos Astithas [:past] from comment #2)
> Verification is possible but also trivial and I'm not sure what we prefer to
> do in these cases. We could definitely skip verification if QA is overloaded.

Thanks Panos.  Marking as QA verify-

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Resolve the 'm' accesskey conflict in the privacy panel

This works.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8632173 [details] [diff] [review]
Resolve the 'm' accesskey conflict in the privacy panel

Review of attachment 8632173 [details] [diff] [review]:
-----------------------------------------------------------------

Is this change OK or do we need to update the entity name here? Note that the related label was just added a few days ago on mozilla-central.

Comment 6

[Axel Hecht [:Pike]]

Comment on attachment 8632173 [details] [diff] [review]
Resolve the 'm' accesskey conflict in the privacy panel

Accesskeys should be OK.

Note, the community l10n alias isn't worth requesting feedback from, nobody's watching that queue.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/a5d32f6f7992

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a5d32f6f7992