If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Resolve the "m" accesskey conflict in the privacy panel

RESOLVED FIXED in Firefox 42

Status

()

Firefox
General
P1
normal
Rank:
9
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: past, Assigned: past)

Tracking

Trunk
Firefox 42
Points:
1
Dependency tree / graph
Bug Flags:
firefox-backlog +
qe-verify -

Firefox Tracking Flags

(firefox42 fixed)

Details

(Whiteboard: [fxprivacy] [campaign])

Attachments

(1 attachment)

In bug 1175920 I have accidentally introduced another checkbox with the "m" accesskey. This bug is for fixing it.
Flags: firefox-backlog?
Iteration: --- → 42.1 - Jul 13
Points: --- → 1
Hi Panos, will this bug require QA verification?
Blocks: 1175000
Rank: 9
Flags: qe-verify?
Flags: needinfo?(past)
Flags: firefox-backlog?
Flags: firefox-backlog+
Verification is possible but also trivial and I'm not sure what we prefer to do in these cases. We could definitely skip verification if QA is overloaded.
Flags: needinfo?(past)
(In reply to Panos Astithas [:past] from comment #2)
> Verification is possible but also trivial and I'm not sure what we prefer to
> do in these cases. We could definitely skip verification if QA is overloaded.

Thanks Panos.  Marking as QA verify-
Flags: qe-verify? → qe-verify-
Created attachment 8632173 [details] [diff] [review]
Resolve the 'm' accesskey conflict in the privacy panel

This works.
Attachment #8632173 - Flags: review?(jaws)
Comment on attachment 8632173 [details] [diff] [review]
Resolve the 'm' accesskey conflict in the privacy panel

Review of attachment 8632173 [details] [diff] [review]:
-----------------------------------------------------------------

Is this change OK or do we need to update the entity name here? Note that the related label was just added a few days ago on mozilla-central.
Attachment #8632173 - Flags: feedback?(community)

Comment 6

2 years ago
Comment on attachment 8632173 [details] [diff] [review]
Resolve the 'm' accesskey conflict in the privacy panel

Accesskeys should be OK.

Note, the community l10n alias isn't worth requesting feedback from, nobody's watching that queue.
Attachment #8632173 - Flags: feedback?(community) → feedback+
Attachment #8632173 - Flags: review?(jaws) → review+

Comment 7

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/a5d32f6f7992

Updated

2 years ago
Iteration: 42.1 - Jul 13 → 42.2 - Jul 27
https://hg.mozilla.org/mozilla-central/rev/a5d32f6f7992
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox42: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42

Updated

2 years ago
Whiteboard: [fxprivacy] → [fxprivacy] [campaign]
You need to log in before you can comment on or make changes to this bug.