Closed Bug 1182545 Opened 9 years ago Closed 9 years ago

Make browser_bug666317.js reliable by being flexible about discard timing

Categories

(Core :: Graphics: ImageLib, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: seth, Assigned: seth)

References

Details

Attachments

(1 file)

Right now browser_bug666317.js expects an image discard notification to be sent within one event loop turn after sending a memory pressure event. Empirically, it sometimes takes a little longer, which causes intermittent failures in this test, especially after bug 1117607.

We can make this test more reliable by just waiting for the discard event, instead of spinning the event loop once and then checking synchronously.

This change may allow this test to finally be turned on for e10s, but I have not checked that yet. We can try it in a followup.
Here's the patch. Hopefully this will finally make this test reliable.
Attachment #8632183 - Flags: review?(tnikkel)
Attachment #8632183 - Flags: review?(tnikkel) → review+
https://hg.mozilla.org/mozilla-central/rev/07bcf36f5ab2
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Blocks: 1184804
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: