Make browser_bug666317.js reliable by being flexible about discard timing

RESOLVED FIXED in Firefox 42

Status

()

Core
ImageLib
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: seth, Assigned: seth)

Tracking

unspecified
mozilla42
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Right now browser_bug666317.js expects an image discard notification to be sent within one event loop turn after sending a memory pressure event. Empirically, it sometimes takes a little longer, which causes intermittent failures in this test, especially after bug 1117607.

We can make this test more reliable by just waiting for the discard event, instead of spinning the event loop once and then checking synchronously.

This change may allow this test to finally be turned on for e10s, but I have not checked that yet. We can try it in a followup.
(Assignee)

Comment 1

3 years ago
Created attachment 8632183 [details] [diff] [review]
Make browser_bug666317.js wait for the discard event instead of expecting it at a precise time

Here's the patch. Hopefully this will finally make this test reliable.
Attachment #8632183 - Flags: review?(tnikkel)
Attachment #8632183 - Flags: review?(tnikkel) → review+
https://hg.mozilla.org/mozilla-central/rev/07bcf36f5ab2
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
(Assignee)

Updated

3 years ago
Blocks: 1184804
You need to log in before you can comment on or make changes to this bug.