Enable use of GetPlatformDisplayEXT and other client extensions in EGL

RESOLVED FIXED in Firefox 42

Status

()

Core
Graphics
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: Kyle Fung, Assigned: Kyle Fung)

Tracking

unspecified
mozilla42
Points:
---

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
We currently query for extensions after having made an EGLDisplay. Client extensions can be queried without creating a display by querying from EGL_NO_DISPLAY.
We need to query for the client extension GetPlatformDisplayEXT without creating an EGLDisplay, so the way display creation is done has to be changed a bit to accommodate extensions that are to be queried without first creating a display.
(Assignee)

Comment 1

3 years ago
Created attachment 8632171 [details] [diff] [review]
display-extensions.patch

Modified the extension querying function to be able to query from different displays. Added support for ANGLE_platform_angle_d3d extension by importing GetPlatformDisplayEXT for EGL when the extension is available.

Info about ANGLE_platform_angle_d3d:
https://www.khronos.org/registry/egl/extensions/EXT/EGL_EXT_platform_base.txt

Info about client extensions (extensions that are display independent):
https://www.khronos.org/registry/egl/extensions/EXT/EGL_EXT_client_extensions.txt
Attachment #8632171 - Flags: review?(jmuizelaar)
Comment on attachment 8632171 [details] [diff] [review]
display-extensions.patch

Review of attachment 8632171 [details] [diff] [review]:
-----------------------------------------------------------------

Seems reasonable to me. You should get jgilbert to do the actual review though.
Attachment #8632171 - Flags: review?(jmuizelaar)
Attachment #8632171 - Flags: review?(jgilbert)
Attachment #8632171 - Flags: feedback+
Comment on attachment 8632171 [details] [diff] [review]
display-extensions.patch

Review of attachment 8632171 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/GLLibraryEGL.h
@@ +156,5 @@
>          AFTER_GL_CALL;
>          return disp;
>      }
>  
> +    EGLDisplay fGetPlatformDisplayEXT(EGLenum platform, void *native_display, const EGLint *attrib_list)

Star to left, against type.
Attachment #8632171 - Flags: review?(jgilbert) → review+
(Assignee)

Comment 4

3 years ago
Created attachment 8632213 [details] [diff] [review]
display-extensions-v2.patch

Fixed styling issue.
Attachment #8632171 - Attachment is obsolete: true
(Assignee)

Comment 5

3 years ago
Try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=079cc7967199
(Assignee)

Comment 6

3 years ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fcfbd3f8ef26
Keywords: checkin-needed

Comment 7

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/3056e4aa89d8
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/3056e4aa89d8
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.