1182547 - Enable use of GetPlatformDisplayEXT and other client extensions in EGL

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Kyle Fung]

We currently query for extensions after having made an EGLDisplay. Client extensions can be queried without creating a display by querying from EGL_NO_DISPLAY.
We need to query for the client extension GetPlatformDisplayEXT without creating an EGLDisplay, so the way display creation is done has to be changed a bit to accommodate extensions that are to be queried without first creating a display.

Comment 1

[Kyle Fung]

Attachment: display-extensions.patch

Modified the extension querying function to be able to query from different displays. Added support for ANGLE_platform_angle_d3d extension by importing GetPlatformDisplayEXT for EGL when the extension is available.

Info about ANGLE_platform_angle_d3d:
https://www.khronos.org/registry/egl/extensions/EXT/EGL_EXT_platform_base.txt

Info about client extensions (extensions that are display independent):
https://www.khronos.org/registry/egl/extensions/EXT/EGL_EXT_client_extensions.txt

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8632171 [details] [diff] [review]
display-extensions.patch

Review of attachment 8632171 [details] [diff] [review]:
-----------------------------------------------------------------

Seems reasonable to me. You should get jgilbert to do the actual review though.

Comment 3

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8632171 [details] [diff] [review]
display-extensions.patch

Review of attachment 8632171 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/GLLibraryEGL.h
@@ +156,5 @@
>          AFTER_GL_CALL;
>          return disp;
>      }
>  
> +    EGLDisplay fGetPlatformDisplayEXT(EGLenum platform, void *native_display, const EGLint *attrib_list)

Star to left, against type.

Comment 4

[Kyle Fung]

Attachment: display-extensions-v2.patch

Fixed styling issue.

Comment 5

[Kyle Fung]

Try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=079cc7967199

Comment 6

[Kyle Fung]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fcfbd3f8ef26

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3056e4aa89d8

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3056e4aa89d8