Closed Bug 1182599 Opened 5 years ago Closed 5 years ago

Startup crash in OOM | large | NS_ABORT_OOM(unsigned int) | nsTArray_base<T>::EnsureCapacity<T>(unsigned int, unsigned int) | nsTArray_base<T>::InsertSlotsAt<T>(unsigned int, unsigned int, unsigned int, unsigned int)

Categories

(Toolkit :: Safe Browsing, defect, critical)

x86
Windows NT
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox40 --- unaffected
firefox41 + fixed
firefox42 --- fixed

People

(Reporter: dmajor, Assigned: gcp)

Details

(Keywords: crash)

Crash Data

Attachments

(1 file)

This bug was filed from the Socorro interface and is 
report bp-9415dc1b-fe9f-49e0-ade0-7adcb2150708.
=============================================================

A few aurora users keep hitting this repeatedly on startup and basically can't use the browser anymore. The allocations are almost 4GB. Perhaps there is an underflow here? http://hg.mozilla.org/releases/mozilla-aurora/annotate/7b0e3c02591f/toolkit/components/url-classifier/nsUrlClassifierPrefixSet.cpp#l322
Flags: needinfo?(gpascutto)
[Tracking Requested - why for this release]: Perma-startup-crash
Assignee: nobody → gpascutto
Flags: needinfo?(gpascutto)
Indeed looks like an underflow caused by a corrupted on disk database.
Attachment #8632848 - Flags: review?(francois)
Attachment #8632848 - Flags: review?(francois) → review+
https://hg.mozilla.org/mozilla-central/rev/38cbbbad1ffe
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Let's track for FF41, we should be uplifting to Aurora at some point once we know the fix is stable.
Comment on attachment 8632848 [details] [diff] [review]
Check for corrupted delta array in UrlClassifier

Approval Request Comment
[Feature/regressing bug #]: None
[User impact if declined]: Irrecoverable startup crash if specific file gets corrupted.
[Describe test coverage new/current, TreeHerder]: None
[Risks and why]: Worst case some legitimate SafeBrowsing databases get wiped.
[String/UUID change made/needed]: None
Attachment #8632848 - Flags: approval-mozilla-aurora?
Comment on attachment 8632848 [details] [diff] [review]
Check for corrupted delta array in UrlClassifier

Approved, seems like a simple check. Let's uplift to Aurora and hope that it helps.
Attachment #8632848 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.