118262 - delete button should be disabled if a card from LDAP directory is selected

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Description

[Ninoschka Baca]

Trunk build 2001-01-04-03: WinMe

Overview: When a card from an LDAP directory is selected in the results pane
then the Delete button should be disabled.

Comment 1

[yulian chang]

Reassign QA contact to myself

Comment 2

[(not reading, please use [e-mail] instead)]

srilatha might be working on this.

other commands would be disabled, like new mailing list, add cards, etc.

note, delete would be enabled if the dir tree had focus, but not if the results
pane has focus.

Comment 3

[Srilatha Moturi]

This is a dup of bug 120423. I would like keep this open since the patch I have 
in 120423 does not disable delete button.
Also regarding the add cards and new mailing list see my comment in bug 120423.
http://bugzilla.mozilla.org/show_bug.cgi?id=120423#c2

Changing summary and taking

Comment 4

[Srilatha Moturi]

Attachment: patch v1

This will disable delete buton when a card from a directory is selected

Comment 5

[(not reading, please use [e-mail] instead)]

the delete button (and edit | delete) should be enabled when LDAP addressbook 
in the dir tree pane has focus, but not when the LDAP cards in the results pane 
have focus.

I don't think this is the right patch.

see DirPaneHasFocus() in abCommon.js, I think you are going to need that.

Comment 6

[Srilatha Moturi]

Seth, I tested this and when I change the focus to dir tree the delete button is 
enabled. Also the code I added, is in ResultsPaneController:isCommandEnabled(). 
so the disabling of the button should happen only if the results pane has focus.

Comment 7

[scottputterman]

Even though this is getting an nsbeta1-, since we have a patch, we should get it
in when it's ready.

Comment 8

[(not reading, please use [e-mail] instead)]

talked with srilatha, she can just use gAbView.directory 
there might not always be a dirTree, and using gAbView.directory will be 
simpler and faster.

Comment 9

[Srilatha Moturi]

Attachment: patch using gAbView.directory

Comment 10

[(not reading, please use [e-mail] instead)]

Comment on attachment 69773 [details] [diff] [review]
patch using gAbView.directory

new patch coming...

Comment 11

[(not reading, please use [e-mail] instead)]

the problem with the last patch is that we use numselected to set the delete 
menu text.

srilatha is working on a new patch.

Comment 12

[Srilatha Moturi]

Attachment: updated patch

updated the patch based on Seth's comments

Comment 13

[(not reading, please use [e-mail] instead)]

Comment on attachment 69785 [details] [diff] [review]
updated patch

one simplifcation:
because you (wisely) made enabled false by default, you can do this:

return (enabled && (numselected > 0));

instead of the if / else.

fix that, and r/sr=sspitzer

Comment 14

[Srilatha Moturi]

Fix checked in 

Comment 15

[yulian chang]

Verified with 2002022103 Wins builds on NT and Win2k