1182626 - Steeplechase_long tests need to be enhanced to run for 3 hours

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P2)

Description

[rshenthar]

It seems like due to recent migration of the webRTC mochitest scripts to ES6, the steeplechase_long scripts have been broken. We need to correct this.

Comment 1

[rshenthar]

Attachment: MozReview Request: Bug 1182626 - Steeplechase_long tests need to be enhanced to run for 3 hours

Bug 1182626 - Steeplechase_long tests need to be enhanced to run for 3 hours

Comment 2

[rshenthar]

Attachment: MozReview Request: Added var for declaration of variable

Added var for declaration of variable

Comment 3

[rshenthar]

Comment on attachment 8633000 [details]
MozReview Request: Bug 1182626 - Steeplechase_long tests need to be enhanced to run for 3 hours

Bug 1182626 - Steeplechase_long tests need to be enhanced to run for 3 hours

Comment 4

[Nils Ohlmeier [:drno]]

Comment on attachment 8633000 [details]
MozReview Request: Bug 1182626 - Steeplechase_long tests need to be enhanced to run for 3 hours

https://reviewboard.mozilla.org/r/13163/#review11891

::: dom/media/moz.build:89
(Diff revision 1)
> +    WEBRTC_SIGNALLING_TEST_MANIFESTS += ['tests/mochitest/steeplechase_long.ini']

I think this change is not needed for fixing the _long functionality, or?

::: dom/media/tests/mochitest/head.js:158
(Diff revision 1)
> +  // This conditional code is meant to handle timeouts for scripts that 
> +  // run for long. The variable STEEPLECHASE_TIMEOUT 
> +  // is optionally set from within the testcase.

I would re-word this into something like:
"The optional declaration of the variable STEEPLECHASE_TIMEOUT allows to override the default script timeout of 30s".

::: dom/media/tests/mochitest/long.js:177
(Diff revision 1)
> + * This function returns a promise that will resolve once the link repeatedly 

Can you please remove the trailing space here?

::: dom/media/tests/mochitest/long.js:213
(Diff revision 1)
> -          test.next();
> +          //test.next();

Please remove this commented code.

::: dom/media/tests/mochitest/long.js:192
(Diff revision 1)
> -  return [
> -    name,
> +  var commandForInterval =
> +    function INTERVAL_COMMAND(test) {

I would prefer if we would simply return the function here directly instead of declaring a variable just to return the variable later.

Comment 5

[Nils Ohlmeier [:drno]]

Comment on attachment 8633001 [details]
MozReview Request: Added var for declaration of variable

https://reviewboard.mozilla.org/r/13165/#review11897

Hmm this change appears empty for me in mozreview.

Comment 6

[Nils Ohlmeier [:drno]]

Comment on attachment 8633000 [details]
MozReview Request: Bug 1182626 - Steeplechase_long tests need to be enhanced to run for 3 hours

https://reviewboard.mozilla.org/r/13163/#review11899

Ship It!

Comment 7

[Nils Ohlmeier [:drno]]

(In reply to Nils Ohlmeier [:drno] from comment #6)
> Comment on attachment 8633000 [details]
> MozReview Request: Bug 1182626 - Steeplechase_long tests need to be enhanced
> to run for 3 hours
> 
> https://reviewboard.mozilla.org/r/13163/#review11899
> 
> Ship It!

Just to be clear: what I meant is "fix it, then ship it" :-)

Comment 8

[rshenthar]

Attachment: MozReview Request: Fixed review comments

Fixed review comments

Comment 9

[rshenthar]

Attachment: MozReview Request: Removed unnecessary ini file change

Removed unnecessary ini file change

Comment 10

[Nils Ohlmeier [:drno]]

Comment on attachment 8633805 [details]
MozReview Request: Fixed review comments

https://reviewboard.mozilla.org/r/13267/#review11933

Ship It!

Comment 11

[Nils Ohlmeier [:drno]]

Comment on attachment 8633809 [details]
MozReview Request: Removed unnecessary ini file change

https://reviewboard.mozilla.org/r/13269/#review11935

Ship It!

Comment 12

[Ryan VanderMeulen (PTO, back July 27)]

Needs to be rebased on inbound tip. Also, can you please squash your commits into one suitable for landing?

Comment 13

[rshenthar]

Comment on attachment 8633000 [details]
MozReview Request: Bug 1182626 - Steeplechase_long tests need to be enhanced to run for 3 hours

Bug 1182626 - Steeplechase_long tests need to be enhanced to run for 3 hours

Comment 14

[rshenthar]

Rebased on inbound and squashed collapsed all =>
https://reviewboard.mozilla.org/r/13161/

Comment 15

[Nils Ohlmeier [:drno]]

Comment on attachment 8633000 [details]
MozReview Request: Bug 1182626 - Steeplechase_long tests need to be enhanced to run for 3 hours

https://reviewboard.mozilla.org/r/13163/#review13623

Ship It!

Comment 16

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ea804beb9ff6

Comment 17

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ea804beb9ff6