Closed Bug 1182632 Opened 9 years ago Closed 9 years ago

Reftest failures due to intermediate compositing on GTK3

Categories

(Core :: Widget: Gtk, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: acomminos, Assigned: acomminos)

References

Details

Attachments

(1 file)

Some reftests on GTK3 fail for widgets due to multiple compositing depending on whether or not we draw the widget to a temporary alpha surface or onto a solid background.

Note that this occurs only when drawing widgets with multiple renderable components, e.g. calling gtk_render_background then gtk_render_frame (this will result in a fuzz of +- 1).

Reftests should be updated accordingly.
This fuzzes reftests that render to a temporary surface for only one reftest case. Thanks!
Attachment #8632291 - Flags: review?(mstange)
Attachment #8632291 - Flags: review?(mstange) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/3bec6b9fa990
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Comment on attachment 8632291 [details] [diff] [review]
Fuzz GTK3 widget reftests that composite differently.

Review of attachment 8632291 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/reftests/xul/reftest.list
@@ +4,5 @@
>  random-if(Android||B2G) fails-if(winWidget) skip-if((B2G&&browserIsRemote)||Mulet) == menulist-shrinkwrap-2.xul menulist-shrinkwrap-2-ref.xul # Initial mulet triage: parity with B2G/B2G Desktop
>  skip-if((B2G&&browserIsRemote)||Mulet) == textbox-overflow-1.xul textbox-overflow-1-ref.xul # for bug 749658 # Initial mulet triage: parity with B2G/B2G Desktop
>  # accesskeys are not normally displayed on Mac, so skip this test
>  skip-if(cocoaWidget) skip-if((B2G&&browserIsRemote)||Mulet) == accesskey.xul accesskey-ref.xul # Initial mulet triage: parity with B2G/B2G Desktop
> +fails-if(cocoaWidget) skip-if((B2G&&browserIsRemote)||Mulet) fuzzy-if(xulRuntime.widgetToolkit=="gtk3",1,11) == tree-row-outline-1.xul tree-row-outline-1-ref.xul # Initial mulet triage: parity with B2G/B2G Desktop

For what it's worth, I'm not sure this one is related to what's mentioned in comment 0. See the differences in http://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/QqUPxL9UQuqDW6pIw7FBJA/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1
Incidentally, I can reproduce on a Firefox build locally (while automation only reproduces on Mulet builds)

Also interestingly, thanks to bug 720684 this unskipped the test on b2g/mulet. I will fix while switching mulet to gtk3 in bug 1186748.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: