1182642 - DOM peer commit hook doesn't accept r=foo,r=webidlpeer

Status: NEW

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Description

[Bobby Holley (:bholley)]

I had this problem in bug 1180921 (see bug 1180921 comment 33). The string in [1] looks like it at least tries to handle this case, at least.

[1] https://hg.mozilla.org/hgcustom/version-control-tools/file/3cc77a4359bf/hghooks/mozhghooks/prevent_webidl_changes.py

Comment 1

[Gregory Szorc [:gps]]

Oh look, more one-off code that does reviewer parsing. We should consolidate around https://hg.mozilla.org/hgcustom/version-control-tools/file/45f5a094da62/pylib/mozautomation/mozautomation/commitparser.py, as that is what's used in MozReview, hg.mozilla.org web view, mozext, etc.

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: MozReview Request: hghooks: use commitparser.py in prevent_webidl_changes.py (bug 1182642)

hghooks: use commitparser.py in prevent_webidl_changes.py (bug 1182642)

The prevent_webidl_changes hook had its own custom way of scraping out
commit reviewers, which doesn't work in certain cases.

We already have commitparser.py, so lets just use it instead.

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

For whatever reason, I'm unable to run ./create-test-environment, so I have no idea if this works or not.

If anyone knows how to deal with the following error, I'm all ears:
  The repository located at downloads.reviewboard.org is not a trusted or secure host and is being ignored. If this repository is available via HTTPS it is recommended to use HTTPS instead, otherwise you may silence this warning and allow it anyways with '--trusted-host downloads.reviewboard.org'.

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 8646729 [details]
MozReview Request: hghooks: use commitparser.py in prevent_webidl_changes.py (bug 1182642)

https://reviewboard.mozilla.org/r/15865/#review14631

While this patch will get the job done, unfortunately, we can't import mozautomation from the hooks because its directory isn't importable. We can't even easily do hacks like look for ../../pylib/mozautomation because the hooks are run out of various directories on the server machine. Well, we could hard-code some paths. But it is very hacky and prone to breakage. And...

I've been working on establishing a more unified environment on the servers for executing hooks. If you wait a few weeks, we can potentially take this patch as is.

If this fix is urgent, we can always copy the mozautomation code for commit message parsing into this hook and clean it up later. I hate DRY violations. But given the state the server is in, I prefer it.

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Happy to leave this for later.