1182643 - [Control Center] panel is closed when I try to change site permissions

Status: VERIFIED FIXED

(Firefox :: General, defect, P1)

Description

[Alice0775 White]

[Tracking Requested - why for this release]:

This problem appears on Nightly42.0a1 but not on Aurora41.0a2.


Steps To Reproduce:
1. Open https://addons.mozilla.org/en-US/firefox/
2. Click "identity-box" in locationbar
3. Attempt to change site permissions:
   Click select box
4. If not reproduce the problem, reload(F5) and go to step2 then step3

Actual Results:
The site identity panel is closed.
So I cannot change it.

Expected Results:
Dropdown list of the site permissions should pop up

Comment 1

[Alice0775 White]

Regression range:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=9442599cebf8&tochange=9a607079f868

Regressed by: 9a607079f868	Tim Taubert — Bug 1180642 - [Control Center] Close panel when an element outside the panel receives focus r=Gijs

Comment 2

[Alice0775 White]

Note,
This should be reproduced without e10s

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

For reasons I don't understand the #main-window gets focus when clicking a pref dropdown. The same thing happens when trying to navigate by hitting <tab>, in non-e10s Firefox only.

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0001-Bug-1182643-Control-Center-Fix-non-e10s-issues-with-.patch

I can't explain what happens in non-e10s mode and why the parent window gets focused when clicking a dropdown but I think we can easily fix this by allowing the identity popup's ancestors to be focused as well. The patch works well for me with and without e10s.

Comment 6

[:Gijs (he/him)]

Comment on attachment 8632788 [details] [diff] [review]
0001-Bug-1182643-Control-Center-Fix-non-e10s-issues-with-.patch

Review of attachment 8632788 [details] [diff] [review]:
-----------------------------------------------------------------

I trust your testing; rs=me

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/4e24a118876c

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4e24a118876c

Comment 9

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8632788 [details] [diff] [review]
0001-Bug-1182643-Control-Center-Fix-non-e10s-issues-with-.patch

Approval Request Comment
[Feature/regressing bug #]: Bug 1180642
[User impact if declined]: Need this to uplift bug 1180642.
[Describe test coverage new/current, TreeHerder]: None.
[Risks and why]: Low risk.
[String/UUID change made/needed]: None.

Comment 10

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8632788 [details] [diff] [review]
0001-Bug-1182643-Control-Center-Fix-non-e10s-issues-with-.patch

Patch looks safe. Let's land it in Aurora.

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/120212c355d1

Comment 12

[Catalin Varga [QA][:VarCat]]

Verified as fixed using:

FF 42 Build Id: 20150728030209
FF 41 Build Id: 20150729004002

OS: Win 7 x64, Ubuntu 14.04 x32, Mac Os X 10.10.4