1182653 - Make ubi::Node infrastructure use JSRuntime* instead of JSContext* so it can be used in more situations

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

I really want to use the ubi::Node infrastructure to find and dump the shortest path to a given thing to stderr for debugging, but a lot of this ubi::Node stuff requires a cx which is maddening.

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

This will also require making callers handle OOMs themselves.

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Use JSRuntime* instead of JSContext* in ubi::Node infrastructure

This enables the use of ubi::Node in situations where a JSContext* is not
available, and paves the way for debugging utilities to dump shortest paths from
GC roots to a given ubi::Node that can be used while paused in a debugger.

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=94cc1f35bdb7

Comment 4

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8664448 [details] [diff] [review]
Use JSRuntime* instead of JSContext* in ubi::Node infrastructure

Review of attachment 8664448 [details] [diff] [review]:
-----------------------------------------------------------------

WFM

::: js/public/UbiNodeTraverse.h
@@ +204,3 @@
>          size_t frontIndex;
>        public:
> +        explicit Queue() : head(), tail(), frontIndex(0) { }

explicit is unnecessary here, now.

Comment 5

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Use JSRuntime* instead of JSContext* in ubi::Node infrastructure

This enables the use of ubi::Node in situations where a JSContext* is not
available, and paves the way for debugging utilities to dump shortest paths from
GC roots to a given ubi::Node that can be used while paused in a debugger.

Comment 6

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

New version drops the now unneeded "explicit" keyword.

Inbound is closed, so checkin-needed for when it opens!

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ffb5c875713f

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ffb5c875713f