Closed Bug 1182658 Opened 7 years ago Closed 7 years ago

Implement TraceNullableRoot so that we can simplify RootMarking

Categories

(Core :: JavaScript: GC, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: terrence, Assigned: terrence)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

This just does the null check internally where we have to null check unconditionally anyway. It saves us a bit of complexity and gets us closer to reifying PersistentRooted and Rooted's marking.
Attachment #8632304 - Flags: review?(jcoppeard)
Attachment #8632304 - Flags: review?(jcoppeard) → review+
Is it possible that this patch somehow affected GC and is responsible for the 6% regression on Splay on Mac 32-bit on AWFY? http://arewefastyet.com/#machine=28&view=single&suite=octane&subtest=Splay
If not, it should at least be one of your other patches in the same regression range.
Flags: needinfo?(terrence)
https://hg.mozilla.org/mozilla-central/rev/719d9b099457
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
No change from backout. Relanding. Moving on to bug 1181869.
Flags: needinfo?(terrence)
Backouts for bug 1182124 and bug 1181869 are also now both in AWFY: still no change. These are not the patches you are looking for.
You need to log in before you can comment on or make changes to this bug.