[Settings] Port checkboxes to use gaia-checkbox

RESOLVED FIXED

Status

Firefox OS
Gaia::Settings
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: kgrandon, Assigned: kgrandon)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

3 years ago
Let's use this bug for porting of the remaining checkboxes first.
Status: NEW → ASSIGNED
Summary: [Settings] Port more switches to use gaia-switch → [Settings] Port checkboxes to use gaia-checkbox
Created attachment 8632335 [details] [review]
[gaia] KevinGrandon:bug_1182670_port_checkboxes_to_gaia_checkbox > mozilla-b2g:master
(Assignee)

Comment 3

3 years ago
Comment on attachment 8632335 [details] [review]
[gaia] KevinGrandon:bug_1182670_port_checkboxes_to_gaia_checkbox > mozilla-b2g:master

Evelyn, or Arthur (not sure if you're still doing reviews), could either of you take a look at this and let me know if it looks ok? Just more web component implementation around the settings app. Thanks!
Attachment #8632335 - Flags: review?(ehung)
Attachment #8632335 - Flags: review?(crh0716)

Comment 4

3 years ago
Comment on attachment 8632335 [details] [review]
[gaia] KevinGrandon:bug_1182670_port_checkboxes_to_gaia_checkbox > mozilla-b2g:master

I didn't check every line changes and just scanned file by file. It looks great, and seems covered everywhere using checkboxes. Thank you so much for doing this for Settings. :)
Attachment #8632335 - Flags: review?(ehung)
Attachment #8632335 - Flags: review?(crh0716)
Attachment #8632335 - Flags: review+
(Assignee)

Comment 5

3 years ago
Thank you for the review! In master: https://github.com/mozilla-b2g/gaia/commit/8c9edeee3a385d60bb6f7b020a6bbf3ad6706740
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
sorry Kevin, had to revert this for test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=2306241&repo=b2g-inbound
Status: RESOLVED → REOPENED
Flags: needinfo?(kgrandon)
Resolution: FIXED → ---
Created attachment 8633830 [details] [review]
[gaia] KevinGrandon:reland_bug_1182670 > mozilla-b2g:master
(Assignee)

Comment 8

3 years ago
Comment on attachment 8633830 [details] [review]
[gaia] KevinGrandon:reland_bug_1182670 > mozilla-b2g:master

Simple updates to fix test locally, carrying review.
Flags: needinfo?(kgrandon)
Attachment #8633830 - Flags: review+
(Assignee)

Updated

3 years ago
Attachment #8632335 - Attachment is obsolete: true
(Assignee)

Comment 9

3 years ago
Tests seem to pass locally, and try is green again. In master: https://github.com/mozilla-b2g/gaia/commit/fc852118726166cee127fd580dc8e37abe830187
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.