1182697 - Fix deprecation warnings shown whilst running Django 1.8

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P3)

Description

[Ed Morley [:emorley]]

vagrant ~/treeherder $ python -Wall manage.py test
/home/vagrant/venv/local/lib/python2.7/site-packages/django_browserid/util.py:9: RemovedInDjango19Warning: django.utils.importlib will be removed in Django 1.9.
  from django.utils.importlib import import_module
/home/vagrant/venv/local/lib/python2.7/site-packages/rest_framework/serializers.py:19: RemovedInDjango19Warning: django.contrib.contenttypes.generic is deprecated and will be removed in Django 1.9. Its contents have been moved to the fields, forms, and admin submodules of django.contrib.contenttypes.
  from django.contrib.contenttypes.generic import GenericForeignKey
/home/vagrant/venv/local/lib/python2.7/site-packages/rest_framework/serializers.py:155: RemovedInDjango19Warning: SortedDict is deprecated and will be removed in Django 1.9.
  return SortedDict(fields)
/home/vagrant/venv/local/lib/python2.7/site-packages/rest_framework/serializers.py:155: RemovedInDjango19Warning: SortedDict is deprecated and will be removed in Django 1.9.
  return SortedDict(fields)
/home/vagrant/venv/local/lib/python2.7/site-packages/rest_framework/serializers.py:155: RemovedInDjango19Warning: SortedDict is deprecated and will be removed in Django 1.9.
  return SortedDict(fields)
Creating test database for alias 'default'...
/home/vagrant/treeherder/treeherder/cache.py:8: RemovedInDjango19Warning: `MemcachedCache._get_memcache_timeout` method should be renamed `get_backend_timeout`.
  class MemcachedCache(memcached.MemcachedCache):
.
----------------------------------------------------------------------
Ran 1 test in 0.015s

OK
Destroying test database for alias 'default'...


vagrant ~/treeherder $ python -Wall manage.py runserver
...

/home/vagrant/venv/local/lib/python2.7/site-packages/django_browserid/util.py:9: RemovedInDjango19Warning: django.utils.importlib will be removed in Django 1.9.
  from django.utils.importlib import import_module

/home/vagrant/venv/local/lib/python2.7/site-packages/rest_framework/serializers.py:19: RemovedInDjango19Warning: django.contrib.contenttypes.generic is deprecated and will be removed in Django 1.9. Its contents have been moved to the fields, forms, and admin submodules of django.contrib.contenttypes.
  from django.contrib.contenttypes.generic import GenericForeignKey

/home/vagrant/venv/local/lib/python2.7/site-packages/rest_framework/serializers.py:155: RemovedInDjango19Warning: SortedDict is deprecated and will be removed in Django 1.9.
  return SortedDict(fields)

/home/vagrant/treeherder/treeherder/cache.py:8: RemovedInDjango19Warning: `MemcachedCache._get_memcache_timeout` method should be renamed `get_backend_timeout`.
  class MemcachedCache(memcached.MemcachedCache):

/home/vagrant/venv/local/lib/python2.7/site-packages/rest_framework/serializers.py:155: RemovedInDjango19Warning: SortedDict is deprecated and will be removed in Django 1.9.
  return SortedDict(fields)

/home/vagrant/treeherder/treeherder/webapp/api/jobs.py:94: PendingDeprecationWarning: action is pending deprecation. Use detail_route instead.
  @action(permission_classes=[IsAuthenticated])
/home/vagrant/treeherder/treeherder/webapp/api/jobs.py:123: PendingDeprecationWarning: action is pending deprecation. Use detail_route instead.
  @action(permission_classes=[IsAuthenticated])
/home/vagrant/treeherder/treeherder/webapp/api/jobs.py:136: PendingDeprecationWarning: action is pending deprecation. Use detail_route instead.
  @action(permission_classes=[IsAuthenticated])
/home/vagrant/treeherder/treeherder/webapp/api/resultset.py:110: PendingDeprecationWarning: link is pending deprecation. Use detail_route instead.
  @link()
/home/vagrant/treeherder/treeherder/webapp/api/resultset.py:119: PendingDeprecationWarning: action is pending deprecation. Use detail_route instead.
  @action(permission_classes=[IsAuthenticated])
/home/vagrant/treeherder/treeherder/webapp/api/resultset.py:155: PendingDeprecationWarning: link is pending deprecation. Use detail_route instead.
  @link()
/home/vagrant/treeherder/treeherder/webapp/api/job_log_url.py:50: PendingDeprecationWarning: action is pending deprecation. Use detail_route instead.
  @action()
/home/vagrant/treeherder/treeherder/webapp/api/job_log_url.py:65: PendingDeprecationWarning: action is pending deprecation. Use detail_route instead.
  @action()

/home/vagrant/venv/local/lib/python2.7/site-packages/rest_framework/routers.py:281: RemovedInDjango19Warning: SortedDict is deprecated and will be removed in Django 1.9.
  api_root_dict = SortedDict()

Comment 1

[Ed Morley [:emorley]]

> /home/vagrant/venv/local/lib/python2.7/site-packages/django_browserid/util.
> py:9: RemovedInDjango19Warning: django.utils.importlib will be removed in
> Django 1.9.
>   from django.utils.importlib import import_module

Fixed in django-browserid v1.0+ (bug 1159167):
https://github.com/mozilla/django-browserid/commit/852d8da9bbc601801779aa98159b9b24483f3692

> /home/vagrant/venv/local/lib/python2.7/site-packages/rest_framework/
> serializers.py:155: RemovedInDjango19Warning: SortedDict is deprecated and
> will be removed in Django 1.9.
>   return SortedDict(fields)

Fixed in django-rest-framework v3.0+:
https://github.com/tomchristie/django-rest-framework/commit/4e001dbb7ac0bc13d6d5fbb4524e905184610aa2
(along with the other django-rest-framework SortedDict instances)

> /home/vagrant/treeherder/treeherder/webapp/api/jobs.py:94:
> PendingDeprecationWarning: action is pending deprecation. Use detail_route
> instead.
>   @action(permission_classes=[IsAuthenticated])

Fixed in the PR in bug 1145712.

Comment 2

[Ed Morley [:emorley]]

With bug 1145712 fixed this just leaves the warnings that will be fixed by bug 1159167, plus:

/home/vagrant/treeherder/treeherder/cache.py:8: RemovedInDjango19Warning: `MemcachedCache._get_memcache_timeout` method should be renamed `get_backend_timeout`.

Comment 3

[Ed Morley [:emorley]]

None of the remaining warnings affect Django 1.8 (we'll need to fix them before Django 1.9 though), so this does not need to block bug 1181879 any more.

Comment 4

[Ed Morley [:emorley]]

vagrant ~/treeherder $ python -Wall manage.py test
...
/home/vagrant/venv/local/lib/python2.7/site-packages/django/conf/__init__.py:122: RemovedInDjango110Warning: Session verification will become mandatory in Django 1.10. Please add 'django.contrib.auth.middleware.SessionAuthenticationMiddleware' to your MIDDLEWARE_CLASSES setting when you are ready to opt-in after reading the upgrade considerations in the 1.8 release notes.


vagrant ~/treeherder $ python -Wall manage.py runserver
...
/home/vagrant/venv/local/lib/python2.7/site-packages/django/conf/__init__.py:122: RemovedInDjango110Warning: Session verification will become mandatory in Django 1.10. Please add 'django.contrib.auth.middleware.SessionAuthenticationMiddleware' to your MIDDLEWARE_CLASSES setting when you are ready to opt-in after reading the upgrade considerations in the 1.8 release notes.

<after accessing local.treeherder.m.o in the browser>

/home/vagrant/treeherder/treeherder/embed/urls.py:9: RemovedInDjango110Warning: django.conf.urls.patterns() is deprecated and will be removed in Django 1.10. Update your urlpatterns to be a list of django.conf.urls.url() instances instead.
  ResultsetStatusView.as_view(), name="resultset_status"),

/home/vagrant/treeherder/treeherder/webapp/api/urls.py:112: RemovedInDjango110Warning: django.conf.urls.patterns() is deprecated and will be removed in Django 1.10. Update your urlpatterns to be a list of django.conf.urls.url() instances instead.
  include(default_router.urls)),

/home/vagrant/venv/local/lib/python2.7/site-packages/django/template/utils.py:37: RemovedInDjango110Warning: You haven't defined a TEMPLATES setting. You must do so before upgrading to Django 1.10. Otherwise Django will be unable to load templates.
  "unable to load templates.", RemovedInDjango110Warning)

/home/vagrant/venv/local/lib/python2.7/site-packages/rest_framework_swagger/urls.py:10: RemovedInDjango110Warning: django.conf.urls.patterns() is deprecated and will be removed in Django 1.10. Update your urlpatterns to be a list of django.conf.urls.url() instances instead.
  url(r'^api-docs/(?P<path>.*)/?$', SwaggerApiView.as_view(), name='django.swagger.api.view'),

/home/vagrant/venv/local/lib/python2.7/site-packages/django_browserid/urls.py:28: RemovedInDjango110Warning: django.conf.urls.patterns() is deprecated and will be removed in Django 1.10. Update your urlpatterns to be a list of django.conf.urls.url() instances instead.
  url(r'^browserid/csrf/$', views.CsrfToken.as_view(), name='browserid.csrf'),

Comment 5

[Ed Morley [:emorley]]

I've opened PRs against the third-party Django packages that are causing some of the deprecation warnings above:
https://github.com/marcgibbons/django-rest-swagger/pull/381
https://github.com/mozilla/django-browserid/pull/295