1182768 - https://www.mozilla.org/en-GB/thunderbird/ offers 32-bit binaries to 64-bit systems

Status: RESOLVED FIXED

(www.mozilla.org Graveyard :: Thunderbird, defect)

Description

[Gervase Markham [:gerv] (not reading bugmail)]

STR:

* Visit https://www.mozilla.org/en-GB/thunderbird/
* Download Thunderbird
* Run Thunderbird

Expected: Thunderbird runs
Actual: bash: /home/gerv/apps/thunderbird/release/thunderbird: No such file or directory
(which is bash's helpful way of saying: you are trying to run a 32-bit binary on a 64-bit system)

My User Agent has the string x86_64 in it, so there's no excuse. If we are going to UA sniff for platform to make the green button give the right file, we should do it right :-)

Gerv

Comment 1

[Gervase Markham [:gerv] (not reading bugmail)]

Also, the green button offers 38.0.1 but the Other Systems and Languages links all offer 38.1.0, which I assume is different...

Gerv

Comment 2

[Wayne Mery (:wsmwk)]

Kohei is this something you can fix up?

Comment 3

[Kohei Yoshino]

I don't have access to the legacy SVN repository except the l10n directory, unfortunately.

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Working on this, stay tuned. Sorry for the delay!

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: thunderbird changes - v1

No idea who to ask for review on this one. Turns out our download buttons are an utter mess. The en-US variant uses the old button, the localized buttons use the new button. Some things are in product-details, others are not.

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: product-details changes - v1

This patch is also needed, it applies to libs/product-details. It changes productDetails.class.php, which in theory is also shared with Firefox. I believe Firefox has migrated everything to bedrock though, so it should be ok to do this. Paul, is this correct?

Comment 8

[Paul [:pmac] McLanahan]

Comment on attachment 8641296 [details] [diff] [review]
product-details changes - v1

Review of attachment 8641296 [details] [diff] [review]:
-----------------------------------------------------------------

Should this work not be done on thunderbirdDetails.class.php? I've not investigated, so I'm sure you're right, but I always thought the TB download button was where that class was used.

Comment 9

[Paul [:pmac] McLanahan]

(In reply to Philipp Kewisch [:Fallen] from comment #6)
> This patch is also needed, it applies to libs/product-details. It changes
> productDetails.class.php, which in theory is also shared with Firefox. I
> believe Firefox has migrated everything to bedrock though, so it should be
> ok to do this. Paul, is this correct?

I think this is right. I'd have to double check what code is left, but this is probably right. Sylvestre is the one who owns and maintains product-details now though I believe, so I'd like him to have a look at this as well.

That said, we're doing all we can to finish porting everything remaining in SVN (all of the PHP) to bedrock this quarter (q3 2015) in preparation for moving bedrock into AWS. So efforts to fix things on the PHP side will help in the short run, but we should make sure this all works when it hits bedrock as well, and potentially it'd be best to just port the page there now in order to fix this as our button facilities there are much more modern and maintained. I'd NI'd Steven Garrity as well since he's leading these porting efforts and may have more up-to-date advice.

Comment 10

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

(In reply to Paul McLanahan [:pmac] from comment #8)
> Should this work not be done on thunderbirdDetails.class.php? I've not
> investigated, so I'm sure you're right, but I always thought the TB download
> button was where that class was used.

I could certainly do this, but I'd either have to overwrite by copy/pasting the whole method, or call the original method and manipulate the html string returned. I was aware that this is a short term solution and we want to move to bedrock for Q3, and suspecting that this code is only used by Thunderbird I went for the easy solution. If needed I can still go for the copy/paste variant.

Comment 11

[Sylvestre Ledru [:Sylvestre]]

(In reply to Paul McLanahan [:pmac] (PTO until 2015-8-10) from comment #9)
> (In reply to Philipp Kewisch [:Fallen] from comment #6)
> > This patch is also needed, it applies to libs/product-details. It changes
> > productDetails.class.php, which in theory is also shared with Firefox. I
> > believe Firefox has migrated everything to bedrock though, so it should be
> > ok to do this. Paul, is this correct?
> 
> I think this is right. I'd have to double check what code is left, but this
> is probably right. Sylvestre is the one who owns and maintains
> product-details now though I believe, so I'd like him to have a look at this
> as well.
That looks OK to me. Do you want me to review (and commit) it?

About the product details PHP api, it is (hopefully) going to die during Q3. For more information, see bug 1083718.
This is a requirement to move some thunderbird pages to bedrock.

Comment 12

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8641296 [details] [diff] [review]
product-details changes - v1

(In reply to Sylvestre Ledru [:sylvestre] from comment #11)
> (In reply to Paul McLanahan [:pmac] (PTO until 2015-8-10) from comment #9)
> > I think this is right. I'd have to double check what code is left, but this
> > is probably right. Sylvestre is the one who owns and maintains
> > product-details now though I believe, so I'd like him to have a look at this
> > as well.
> That looks OK to me. Do you want me to review (and commit) it?
That would be great, thanks for offering! Can you take a quick glance at the thunderbird changes too?

> 
> About the product details PHP api, it is (hopefully) going to die during Q3.
> For more information, see bug 1083718.
> This is a requirement to move some thunderbird pages to bedrock.
Great, looking forward to this. ship-it is a perfect match, glad to hear.

Comment 13

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8641296 [details] [diff] [review]
product-details changes - v1

This should not have an impact on the Firefox website. It won't impact product detail usage done by Firefox & bedrock.

Besides that, your patch looks good but I haven't been able to test it.

Do you want me to commit it for you?

Comment 14

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8641293 [details] [diff] [review]
thunderbird changes - v1

I don't know this part, sorry.

Comment 15

[Steven Garrity [:sgarrity]]

(In reply to Paul [:pmac] McLanahan from comment #9)
> (In reply to Philipp Kewisch [:Fallen] from comment #6)
> > This patch is also needed, it applies to libs/product-details. It changes
> > productDetails.class.php, which in theory is also shared with Firefox. I
> > believe Firefox has migrated everything to bedrock though, so it should be
> > ok to do this. Paul, is this correct?
> 
> I think this is right. I'd have to double check what code is left, but this
> is probably right. Sylvestre is the one who owns and maintains
> product-details now though I believe, so I'd like him to have a look at this
> as well.
> 
> That said, we're doing all we can to finish porting everything remaining in
> SVN (all of the PHP) to bedrock this quarter (q3 2015) in preparation for
> moving bedrock into AWS. So efforts to fix things on the PHP side will help
> in the short run, but we should make sure this all works when it hits
> bedrock as well, and potentially it'd be best to just port the page there
> now in order to fix this as our button facilities there are much more modern
> and maintained. I'd NI'd Steven Garrity as well since he's leading these
> porting efforts and may have more up-to-date advice.

If my comment is still relevant, the only place the PHP-based Firefox download button is still used is on the PHP-based 404 pages (https://www.mozilla.org/en-US/asdf). This could be replaced with a static link to the bedrock download page, but I was hoping not to touch them at all.

Comment 16

[Kohei Yoshino]

I'll port the rest of the Thunderbird pages to Bedrock next week.

Comment 17

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8641293 [details] [diff] [review]
thunderbird changes - v1

Thanks for the note. So do you think it is still worth pushing these patches? If so, maybe you can take a quick look at the Thunderbird changes in this patch so we can push it.

Comment 18

[Kohei Yoshino]

I meant the Thunderbird pages _including_ this landing page, so yes, I'd recommend just waiting for the migration that will happen in a few weeks. Actually this bug is a duplicate of Bug 1173861 which is dup'd of Bug 836462.

Comment 19

[Kohei Yoshino]

Haha, I have just encountered this bug myself ;) And the console dumps such a confusing error. That's why I ____ Linux.

> /usr/lib/thunderbird-official/thunderbird: No such file or directory

Comment 20

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

(In reply to Kohei Yoshino [:kohei] from comment #18)
> I meant the Thunderbird pages _including_ this landing page, so yes, I'd
> recommend just waiting for the migration that will happen in a few weeks.
> Actually this bug is a duplicate of Bug 1173861 which is dup'd of Bug 836462.

Few weeks or next week? If this is fixed in the coming week we might as well just wait, if you think it might be postponed a few weeks, I'd rather just push it since the patches are there.

Comment 21

[Sylvestre Ledru [:Sylvestre]]

(In reply to Kohei Yoshino [:kohei] from comment #19)
> Haha, I have just encountered this bug myself ;) And the console dumps such
> a confusing error. That's why I ____ Linux.
> 
> > /usr/lib/thunderbird-official/thunderbird: No such file or directory
btw, thunderbird could check that itself....

Comment 22

[Kohei Yoshino]

Next week at earliest. I'm about to work on it today.

Comment 24

[Kohei Yoshino]

Comment on attachment 8641293 [details] [diff] [review]
thunderbird changes - v1

Review of attachment 8641293 [details] [diff] [review]:
-----------------------------------------------------------------

The new landing page is coming tomorrow. Clearing the review flag.

Comment 25

[Kohei Yoshino]

The landing page code is now merged!