1182782 - Changing multiple bugs at once can fail if the dontchange text has been localized

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Marc Schumann [:Wurblzap]]

This is a regression of bug 281791 affecting (at least) 5.0 and trunk.

If the dontchange pseudo-constant of
template/en/default/list/edit-multiple.html.tmpl has been localized (i. e. is something else than the default --do_not_change--), changing multiple bugs at once fails if there is at least one flag type which might be set or unset and the user doesn't want the flags of this type to be changed (i. e. selects the dontchange option).

This is because template/en/default/flag/list.html.tmpl has --do_not_change-- hardcoded instead of using the value set by edit-multiple.html.tmpl.

Comment 1

[Simon Green]

Attachment: bug1182782-v1.patch

Comment 2

[Marc Schumann [:Wurblzap]]

Comment on attachment 8632695 [details] [diff] [review]
bug1182782-v1.patch

Review of attachment 8632695 [details] [diff] [review]:
-----------------------------------------------------------------

::: template/en/default/flag/list.html.tmpl
@@ +121,5 @@
>                  class="flag_select flag_type-[% type.id %]"
>                  [% IF !can_edit_flag %] disabled="disabled"[% END %]>
>          [%# Only display statuses the user is allowed to set. %]
> +        [% IF edit_multiple_bugs && dontchange %]
> +          <option value="[% dontchange FILTER html %]">[% dontchange FILTER html %]</option>

Shouldn't edit-multiple.html.tmpl formally pass in dontchange, like it does to product-select.html.tmpl?

Comment 3

[Simon Green]

(In reply to Marc Schumann [:Wurblzap] from comment #2)
> Shouldn't edit-multiple.html.tmpl formally pass in dontchange, like it does
> to product-select.html.tmpl?

I don't think so, but I'll leave it for dkl to decide.

Comment 4

[David Lawrence [:dkl]]

Comment on attachment 8632695 [details] [diff] [review]
bug1182782-v1.patch

Review of attachment 8632695 [details] [diff] [review]:
-----------------------------------------------------------------

This fine as is. r=dkl

Comment 5

[Simon Green]

To ssh://[e-mail]/bugzilla/bugzilla.git
   f1ac494..20c3fa7  master -> master

To ssh://[e-mail]/bugzilla/bugzilla.git
   92ebe5b..607d89d  5.0 -> 5.0