1182798 - Change the exit status of a Firefox UI update job if any of the update tests fails

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Armen [:armenzg]]

We now add a summary at the end of a run [1].
We should change the return code of the script if any locale fails.

This is a very simple fix.

[1] http://hg.mozilla.org/build/mozharness/file/default/scripts/firefox_ui_updates.py#l366

Comment 1

[Armen [:armenzg]]

Attachment: [mozharness] status summary and set exit code

Comment 2

[Jordan Lund (:jlund)]

Comment on attachment 8638040 [details] [diff] [review]
[mozharness] status summary and set exit code

Review of attachment 8638040 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/mozharness/scripts/firefox_ui_updates.py
@@ +429,5 @@
>                          failed_locales.append(locale)
> +
> +                if failed_locales:
> +                    if exit_status == TBPL_SUCCESS:
> +                        self.info("\nSUMMARY - Firefox UI update tests failed locales:")

why the /n ? Does that work with mh loggging?

@@ +436,5 @@
> +
> +                    self.info(build_id)
> +                    self.info("  %s" % (', '.join(failed_locales)))
> +
> +            self.return_code = EXIT_STATUS_DICT[exit_status] 

question:

This will assign self.return_code with TBPL_SUCCESS or TBPL_WARNING regardless if you have already set that to something worse before hand.

Even if you don't touch self.return_code outside of this, would it be worth future proofing with something like: http://mxr.mozilla.org/build/source/mozharness/mozharness/mozilla/building/buildbase.py#1365 ?

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dbbf6ea2dd0c

Comment 4

[Armen [:armenzg]]

I removed the \n and added a self.info("") before just in case Windows does something funky.

I'm happy to leave the setting of return codes as-is.
I just want to wrap this up and I don't foresee changes to this.

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/dbbf6ea2dd0c

Comment 6

[Armen [:armenzg]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/66a9675c2d40

Comment 7

[Armen [:armenzg]]

https://hg.mozilla.org/releases/mozilla-beta/rev/bcd72a368f81

Comment 8

[Armen [:armenzg]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/66a9675c2d40