Closed Bug 1182840 Opened 9 years ago Closed 8 years ago

Generated SDK headers should depend on changes in annotation processor

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox42 affected, firefox51 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla51
Tracking Flags:
Tracking Status
firefox42 --- affected
firefox51 --- fixed

People

(Reporter: jchen, Unassigned)

Details

Attachments

(1 file)

Make generated SDK bindings depend on annotation processor (v1)
1.92 KB, patch
snorp
: review+
Details | Diff | Splinter Review 
Currently there's no build system dependency between the generated SDK headers and the in-tree JNI headers (i.e. widget/android/jni/Refs.h). This may require a CLOBBER that's not obvious (e.g. bug 1178850).
Component: General → Build Config
Product: Firefox for Android → Core
Make the generated SDK binding files depend on the annotation processor
jar file, so that changes in the annotation processor will cause the
bindings to regenerate.
Attachment #8783728 - Flags: review?(snorp)
Summary: Generated SDK headers should depend on changes in JNI headers → Generated SDK headers should depend on changes in annotation processor
Attachment #8783728 - Flags: review?(snorp) → review+
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ca1fbb8218da
Make generated SDK bindings depend on annotation processor; r=snorp
https://hg.mozilla.org/mozilla-central/rev/ca1fbb8218da
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: