Generated SDK headers should depend on changes in annotation processor

RESOLVED FIXED in Firefox 51

Status

()

Core
Build Config
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: jchen, Unassigned)

Tracking

Trunk
mozilla51
All
Android
Points:
---

Firefox Tracking Flags

(firefox42 affected, firefox51 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
Currently there's no build system dependency between the generated SDK headers and the in-tree JNI headers (i.e. widget/android/jni/Refs.h). This may require a CLOBBER that's not obvious (e.g. bug 1178850).

Updated

3 years ago
Component: General → Build Config
Product: Firefox for Android → Core
(Reporter)

Comment 1

2 years ago
Created attachment 8783728 [details] [diff] [review]
Make generated SDK bindings depend on annotation processor (v1)

Make the generated SDK binding files depend on the annotation processor
jar file, so that changes in the annotation processor will cause the
bindings to regenerate.
Attachment #8783728 - Flags: review?(snorp)
(Reporter)

Updated

2 years ago
Summary: Generated SDK headers should depend on changes in JNI headers → Generated SDK headers should depend on changes in annotation processor
Attachment #8783728 - Flags: review?(snorp) → review+

Comment 2

2 years ago
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ca1fbb8218da
Make generated SDK bindings depend on annotation processor; r=snorp

Comment 3

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ca1fbb8218da
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.