Use the built-in entries for test-track-simple and test-trackwhite-simple in mochitests

REOPENED
Unassigned

Status

()

Toolkit
Safe Browsing
P3
normal
REOPENED
3 years ago
2 months ago

People

(Reporter: francois, Unassigned)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

3 years ago
We currently have test-phish-simple and the likes for Safe Browsing unit tests. We need the same thing for tracking protection.
(Reporter)

Comment 1

3 years ago
I have suggested that some test files be served from the same domain as the shavar server: https://github.com/mozilla-services/shavar/issues/43
(Reporter)

Comment 2

3 years ago
I've just registered two domains that I will be adding to the test list:

- itisatracker.org
- itisatracker.com
(Reporter)

Comment 3

3 years ago
Created attachment 8635496 [details]
MozReview Request: Bug 1182876 - Add test-track-simple list for testing TP. r?dcamp

Bug 1182876 - Add test-track-simple list for testing TP. r?dcamp
Attachment #8635496 - Flags: review?(dcamp)
(Reporter)

Comment 5

3 years ago
Comment on attachment 8635496 [details]
MozReview Request: Bug 1182876 - Add test-track-simple list for testing TP. r?dcamp

Bug 1182876 - Add test-track-simple list for testing TP. r?dcamp
Attachment #8635496 - Flags: review?(dcamp)
(Reporter)

Updated

3 years ago
Summary: Create test-track-simple to provide a stable tracking URL for testing purposes → Use the built-in entries for test-track-simple and test-trackwhite-simple in mochitests
(Reporter)

Comment 6

3 years ago
Comment on attachment 8635496 [details]
MozReview Request: Bug 1182876 - Add test-track-simple list for testing TP. r?dcamp

The URLs themselves were added in bug 1185549.

I will simplify the mochitests so that they use the built-in URLs and don't require toolkit/components/url-classifier/tests/UrlClassifierTestUtils.jsm anymore.
Attachment #8635496 - Attachment is obsolete: true
(Reporter)

Comment 7

3 years ago
The test-trackwhite-simple table will be added in bug 1141352.
No longer blocks: 1149825
Depends on: 1141352
Status: NEW → ASSIGNED
Whiteboard: [domsecurity-active]
(Reporter)

Updated

2 years ago
Assignee: francois → nobody
Status: ASSIGNED → NEW
Component: DOM: Security → Safe Browsing
Product: Core → Toolkit
Whiteboard: [domsecurity-active]
(Reporter)

Updated

2 years ago
Priority: -- → P2
(Reporter)

Updated

2 years ago
Priority: P2 → P3
(Reporter)

Comment 9

2 years ago
Created attachment 8782694 [details] [diff] [review]
WIP patch (UI tests)
:francois, can you work on getting these fixes in place so we can see bug 1214437 fixed or reduced?
Flags: needinfo?(francois)
(Reporter)

Comment 11

a year ago
(In reply to Joel Maher ( :jmaher) from comment #10)
> :francois, can you work on getting these fixes in place so we can see bug
> 1214437 fixed or reduced?

How important would you say it is? I probably won't have time to look at it for several weeks but I can try to find someone else if you think it should be prioritized higher than a P3.
Flags: needinfo?(francois) → needinfo?(jmaher)
This showed up as a potential fix for a high frequency intermittent last week.  Overall, the frequency of that specific failure went down quite a bit- So I would like to see this in, but I don't think we should prioritize it above other work.  If we can have this landed next month, that would be ideal.  If bug 1214437 picks up in frequency again, I will check back in here.
Flags: needinfo?(jmaher)
(Reporter)

Updated

a year ago
See Also: → bug 1203438
the failure rate of these tests have been greatly reduced, not sure if it is coincidence or a fix!

Comment 14

2 months ago
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Status: NEW → RESOLVED
Last Resolved: 2 months ago
Resolution: --- → INACTIVE
(Reporter)

Updated

2 months ago
Status: RESOLVED → REOPENED
Resolution: INACTIVE → ---
You need to log in before you can comment on or make changes to this bug.