Closed Bug 1182894 Opened 4 years ago Closed 4 years ago

Hiding markers can hide different markers

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

41 Branch
defect
Not set

Tracking

(firefox42 fixed)

RESOLVED FIXED
Firefox 42
Tracking Status
firefox42 --- fixed

People

(Reporter: jsantell, Assigned: jsantell)

References

()

Details

Attachments

(1 file)

Can't describe this one well, so here's a gif.

When hiding "Function Calls", all of the "DOM Events" are hidden as well except one. Most markers are DOM Events enveloping Function Calls. This is very weird.

Profile: https://bugzilla.mozilla.org/attachment.cgi?id=8625553
(In reply to Jordan Santell [:jsantell] [@jsantell] from comment #0)
> Can't describe this one well, so here's a gif.

BROKEN PROMISES
i wish :[ attached in the URL field: http://i.imgur.com/bnbyRob.gif
Looks like bug 1176537 fixes this, but need to write a test for that -- I thought we had something similar, but I guess we don't have an xpcshell test for both filtering and collapsing in one go.
Depends on: 1176537
Assignee: nobody → jsantell
Status: NEW → ASSIGNED
Looks like that marker fix did fix this as well. Here's a test ensuring that.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9e4e06c31269
Attachment #8633849 - Flags: review?(vporof)
Attachment #8633849 - Flags: review?(vporof) → review+
https://hg.mozilla.org/mozilla-central/rev/1fc0f9821100
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.