11829 - Sidebar animated GIF flickers even if sidebar closed

Status: VERIFIED WORKSFORME

(Core :: Graphics: ImageLib, defect, P3)

Description

[Simon Fraser [no longer active]]

I have a build with double-buffering off, and I'm seeing some image redraw when
none should take place (on Mac)

First, build with double buffering off (this allows you to see the flicker). The
switch is in mozilla/view/nsViewManager.cpp.
Now, in the sidebar, ensure that the 'Flashes' panel is expanded. You should see
the small "flames" animated GIF.
Now close the sidebar, and load a page with a plain, non-white background.
You should be able to see a flickering rectangle where the flame animated GIF
would be if the sidebar were open.

Comment 1

[pnunn]

I'm not sure if this is mine, or for a layout engineer.
Or network.
I'll dig into it and find out.
-pn

Comment 2

[Eli Goldberg]

[cc:ing paulmac, who tests sidebar]

Comment 3

[pnunn]

I think this is a duplicate, but I can't remember to whom
the bug was assigned.

Comment 4

[pnunn]

Simon:
Is this bug still pertinent??
If it is, please reassign it back to
me....This sounds like a bug that
was fixed ages ago by one of Patrick's
checkins.
-pn

Comment 5

[Simon Fraser [no longer active]]

We ain't seen this for a long time, and alas the animated gif is no longer in the
sidebarf to test with. Workingforme.

Comment 6

[Eli Goldberg]

Rubber-stamping as verified/worksforme.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be6abdda8424
[components] Fix for  https://github.com/mozilla-mobile/android-components/issues/11829: Have the additional_note from the context menu sticky