Closed
Bug 1182926
Opened 9 years ago
Closed 9 years ago
Fix "observer-service-suspect" bustage
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla42
Tracking | Status | |
---|---|---|
firefox42 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
Details
Attachments
(1 file)
4.00 KB,
patch
|
poiru
:
review+
|
Details | Diff | Splinter Review |
In bug 1181445 I messed up the enumerate-to-iterate conversion in nsObserverService::CollectReports(), which is causing it to report numbers that are much too high. I accidentally caused the running total to be used for each topic's count, as the following output shows: > 86,904 (100.0%) -- observer-service-suspect > ├─────796 (00.92%) ── referent(topic=oop-frameloader-crashed) > ├─────795 (00.91%) ── referent(topic=gather-telemetry) > ├─────793 (00.91%) ── referent(topic=webapps-ask-uninstall) > ├─────792 (00.91%) ── referent(topic=spellcheck-dictionary-update) > ├─────791 (00.91%) ── referent(topic=message-manager-close) > ├─────786 (00.90%) ── referent(topic=profile-change-net-teardown) > ├─────782 (00.90%) ── referent(topic=keyword-search) > ├─────781 (00.90%) ── referent(topic=agent-sheet-removed) > ├─────765 (00.88%) ── referent(topic=profile-initial-state) > ├─────763 (00.88%) ── referent(topic=social:ambient-notification-changed) > ├─────762 (00.88%) ── referent(topic=child-gc-request) > ├─────761 (00.88%) ── referent(topic=plugin-crashed) > ├─────759 (00.87%) ── referent(topic=weave:engine:clients:display-uri) > ├─────758 (00.87%) ── referent(topic=xpi-signature-changed) > ├─────757 (00.87%) ── referent(topic=xpcom-category-entry-added) > ├─────751 (00.86%) ── referent(topic=author-style-disabled-changed) Notice the monotonically increasing values. Fortunately it's an easy fix.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8632596 -
Flags: review?(birunthan)
Updated•9 years ago
|
Attachment #8632596 -
Flags: review?(birunthan) → review+
https://hg.mozilla.org/mozilla-central/rev/98b61e7948cf
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•