1182960 - Use nsTHashTable::Iterator in toolkit/

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[Nicholas Nethercote [inactive]]

Because iterators are so much nicer than enumerate functions.

There are ten occurrences of EnumerateEntries() in toolkit/ to be dealt with.

Comment 1

[Nicholas Nethercote [inactive]]

> There are ten occurrences of EnumerateEntries() in toolkit/ to be dealt with.

Correction: there are only eight occurrences. There are two false positive matches when you grep for EnumerateEntries() because there's a local function with that name which, ironically enough, is passed as an argument to an nsBaseHashtable::Enumerate() call.

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: (part 1) - Use nsTHashtable::Iterator in toolkit/components/telemetry/

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: (part 2) - Use nsTHashtable::Iterator in toolkit/components/places/

Comment 4

[Marco Bonardo [:mak]]

Comment on attachment 8633477 [details] [diff] [review]
(part 2) - Use nsTHashtable::Iterator in toolkit/components/places/

Review of attachment 8633477 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/places/nsFaviconService.cpp
@@ +157,5 @@
>    }
>  
>    PRTime now = PR_Now();
> +  for (auto iter = mUnassociatedIcons.Iter(); !iter.Done(); iter.Next()) {
> +    if (now - iter.Get()->created >= UNASSOCIATED_ICON_EXPIRY_INTERVAL) {

please factor out iter.Get() for readability and showing an explicit type

Comment 5

[Marco Bonardo [:mak]]

Comment on attachment 8633476 [details] [diff] [review]
(part 1) - Use nsTHashtable::Iterator in toolkit/components/telemetry/

Review of attachment 8633476 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/774c08a56c10
https://hg.mozilla.org/integration/mozilla-inbound/rev/a32e92330e99

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/774c08a56c10
https://hg.mozilla.org/mozilla-central/rev/a32e92330e99