Use nsTHashTable::Iterator in caps/

RESOLVED FIXED in Firefox 42

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: njn, Assigned: mccr8)

Tracking

unspecified
mozilla42
Points:
---

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(3 attachments)

(Reporter)

Description

4 years ago
Because iterators are so much nicer than enumerate functions.

There is one occurrence of EnumerateEntries() in layout/{style,svg}/ to be dealt with.
(Reporter)

Comment 1

4 years ago
> There is one occurrence of EnumerateEntries() in layout/{style,svg}/ to be
> dealt with.

Sorry, that should be "caps/", not "layout/{style,svg}/".
(Assignee)

Updated

4 years ago
Assignee: nobody → continuation
(Assignee)

Comment 2

4 years ago
Created attachment 8633497 [details] [diff] [review]
part 1 - Use nsTHashTable::Iterator in DomainSet::CloneSet.

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=aa78f6832829
Attachment #8633497 - Flags: review?(mrbkap)
(Assignee)

Comment 3

4 years ago
Created attachment 8633498 [details] [diff] [review]
part 2 - Stop referring to the nsI class for no apparent reason in DomainPolicy.

While I was here, I threw in a few minor cleanups. For some reason, I needed the .get() when assigning from a refptr to a comptr.
Attachment #8633498 - Flags: review?(mrbkap)
(Assignee)

Comment 4

4 years ago
Created attachment 8633499 [details] [diff] [review]
part 3 - Add some final annotations to DomainSet.

I'm not entirely sure what these do, but it seems like a bad idea to extend them.
Attachment #8633499 - Flags: review?(mrbkap)
Attachment #8633497 - Flags: review?(mrbkap) → review+
Attachment #8633498 - Flags: review?(mrbkap) → review+
Attachment #8633499 - Flags: review?(mrbkap) → review+
(Assignee)

Comment 5

4 years ago
Thanks for the reviews.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c25cbd21c168
https://hg.mozilla.org/mozilla-central/rev/7de43f04cd0a
https://hg.mozilla.org/mozilla-central/rev/20e4f7dcee9c
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.