1182966 - Use nsTHashTable::Iterator in caps/

Status: RESOLVED FIXED

(Core :: Security: CAPS, defect)

Description

[Nicholas Nethercote [inactive]]

Because iterators are so much nicer than enumerate functions.

There is one occurrence of EnumerateEntries() in layout/{style,svg}/ to be dealt with.

Comment 1

[Nicholas Nethercote [inactive]]

> There is one occurrence of EnumerateEntries() in layout/{style,svg}/ to be
> dealt with.

Sorry, that should be "caps/", not "layout/{style,svg}/".

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: part 1 - Use nsTHashTable::Iterator in DomainSet::CloneSet.

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=aa78f6832829

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: part 2 - Stop referring to the nsI class for no apparent reason in DomainPolicy.

While I was here, I threw in a few minor cleanups. For some reason, I needed the .get() when assigning from a refptr to a comptr.

Comment 4

[Andrew McCreight [:mccr8]]

Attachment: part 3 - Add some final annotations to DomainSet.

I'm not entirely sure what these do, but it seems like a bad idea to extend them.

Comment 5

[Andrew McCreight [:mccr8]]

Thanks for the reviews.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c25cbd21c168
https://hg.mozilla.org/integration/mozilla-inbound/rev/7de43f04cd0a
https://hg.mozilla.org/integration/mozilla-inbound/rev/20e4f7dcee9c

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c25cbd21c168
https://hg.mozilla.org/mozilla-central/rev/7de43f04cd0a
https://hg.mozilla.org/mozilla-central/rev/20e4f7dcee9c