1182975 - Use nsTHashTable::Iterator in dom/xbl/

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Nicholas Nethercote [inactive]]

Because iterators are so much nicer than enumerate functions.

There are seven occurrences of EnumerateEntries() in dom/xbl/ to be dealt with.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: part 1 - Use early return consistently when iterating over mBoundContentSet.

Once I start inlining the enumerator methods, I think it makes sense to have the early return.

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=aa78f6832829

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: part 2 - Convert EnumRuleProcessors to use an iterator.

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: part 3 - Convert the rest of the uses of EnumerateEntries in nsBindingManager to Iterator().

Sorry for the slightly mashed together diff here.

Comment 4

[Nicholas Nethercote [inactive]]

All three patches look good to me.

Comment 5

[Andrew McCreight [:mccr8]]

Thanks for the reviews.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/37a4a77ab5a6
https://hg.mozilla.org/integration/mozilla-inbound/rev/31b7f9a8f243
https://hg.mozilla.org/integration/mozilla-inbound/rev/bd3b1119982a

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/37a4a77ab5a6
https://hg.mozilla.org/mozilla-central/rev/31b7f9a8f243
https://hg.mozilla.org/mozilla-central/rev/bd3b1119982a