Use nsTHashTable::Iterator in dom/xbl/

RESOLVED FIXED in Firefox 42

Status

()

Core
DOM
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: njn, Assigned: mccr8)

Tracking

unspecified
mozilla42
Points:
---

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(3 attachments)

Because iterators are so much nicer than enumerate functions.

There are seven occurrences of EnumerateEntries() in dom/xbl/ to be dealt with.
(Assignee)

Updated

3 years ago
Assignee: nobody → continuation
(Assignee)

Comment 1

3 years ago
Created attachment 8633508 [details] [diff] [review]
part 1 - Use early return consistently when iterating over mBoundContentSet.

Once I start inlining the enumerator methods, I think it makes sense to have the early return.

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=aa78f6832829
Attachment #8633508 - Flags: review?(wchen)
(Assignee)

Comment 2

3 years ago
Created attachment 8633509 [details] [diff] [review]
part 2 - Convert EnumRuleProcessors to use an iterator.
Attachment #8633509 - Flags: review?(wchen)
(Assignee)

Comment 3

3 years ago
Created attachment 8633510 [details] [diff] [review]
part 3 - Convert the rest of the uses of EnumerateEntries in nsBindingManager to Iterator().

Sorry for the slightly mashed together diff here.
Attachment #8633510 - Flags: review?(wchen)
All three patches look good to me.

Updated

3 years ago
Attachment #8633508 - Flags: review?(wchen) → review+

Updated

3 years ago
Attachment #8633509 - Flags: review?(wchen) → review+

Updated

3 years ago
Attachment #8633510 - Flags: review?(wchen) → review+
(Assignee)

Comment 5

3 years ago
Thanks for the reviews.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/37a4a77ab5a6
https://hg.mozilla.org/mozilla-central/rev/31b7f9a8f243
https://hg.mozilla.org/mozilla-central/rev/bd3b1119982a
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.