Closed Bug 1182975 Opened 6 years ago Closed 6 years ago

Use nsTHashTable::Iterator in dom/xbl/

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: njn, Assigned: mccr8)

References

Details

Attachments

(3 files)

Because iterators are so much nicer than enumerate functions.

There are seven occurrences of EnumerateEntries() in dom/xbl/ to be dealt with.
Assignee: nobody → continuation
Once I start inlining the enumerator methods, I think it makes sense to have the early return.

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=aa78f6832829
Attachment #8633508 - Flags: review?(wchen)
Sorry for the slightly mashed together diff here.
Attachment #8633510 - Flags: review?(wchen)
All three patches look good to me.
Attachment #8633508 - Flags: review?(wchen) → review+
Attachment #8633509 - Flags: review?(wchen) → review+
Attachment #8633510 - Flags: review?(wchen) → review+
Thanks for the reviews.
Keywords: checkin-needed
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.