1183038 - When hiding the activity picker because of an |appopened|, the system should cancel the activity

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Lance（leave from Mozilla）]

Attachment: logcat_0440.txt

[1.Description]:
[Flame v2.2][Nexus 5 v2.2][Message]In contact detail view, tap "share contact", after the "Share with:" screen is shown, launch "Settings" from notification bar, then return to contact detail view, tap the "share contact" again, then select message, and you will find there are two same .vcf files shown in the message edit screen.

See attachment: Flame_V2.2.3gp, logcat_0440.txt 
Found at: 4:40

[2.Testing Steps]: 
1. Launch contact app;
2. Tap one contact;
3. Tap "Share contact";
4. Expand the notification bar
5. Tap Settings
6. Swip to contact app
7. Repeat step 3;
8. Select 'Messages' and observe;

[3.Expected Result]: 
8. New message screen is shown, and there is just one .vcf file.

[4.Actual Result]: 
8. In the "New message" screen, there are two .vcf files added as attachment.

[5.Reproduction build]: 
Flame2.2 build (Affected):
Build ID               20150712002506
Gaia Revision          84d0c76370dcd3d25813b00de55194730884355b
Gaia Date              2015-07-09 13:09:14
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/8d59402ba85a
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150712.040416
Firmware Date          Sun Jul 12 04:04:27 EDT 2015
Bootloader             L1TC000118D0

Nexus5_2.2 build(Affected):
Build ID               20150712002506
Gaia Revision          84d0c76370dcd3d25813b00de55194730884355b
Gaia Date              2015-07-09 13:09:14
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/8d59402ba85a
Gecko Version          37.0
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150712.040340
Firmware Date          Sun Jul 12 04:03:59 EDT 2015
Bootloader             HHZ12f

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
Free Test

[8. Note]:
I can't do the STR on master because of the OOM bug 1162535, when I do the step 8, message app will be killed automatically.

Comment 1

[Lance（leave from Mozilla）]

Attachment: Flame_V2.2.3gp

Comment 2

[Julien Wajsberg [:julienw] (PTO -> Mar 16)]

I believe this is a System issue, we likely get 2 system messages at that moment.

When we switch back to Contacts, I believe we should still have the activity request window. What do you think Etienne?

Comment 3

[Etienne Segonzac (:etienne)]

(In reply to Julien Wajsberg [:julienw] from comment #2)
> I believe this is a System issue, we likely get 2 system messages at that
> moment.
> 
> When we switch back to Contacts, I believe we should still have the activity
> request window. What do you think Etienne?

The activity picker is modal at the system level. Closing it when moving to another app [1] is fine and consistent with closing it when we go home.

But, we need to cancel the activity [2] when we close it.

[1] https://github.com/mozilla-b2g/gaia/blob/2f36e9c506586def9f062b80081c3854985a0ea1/apps/system/js/activities.js#L64
[2] https://github.com/mozilla-b2g/gaia/blob/2f36e9c506586def9f062b80081c3854985a0ea1/apps/system/js/activities.js#L64

Comment 4

[Etienne Segonzac (:etienne)]

I've heard this is proving hard to reproduce, would be great for QA to confirm this.

Comment 5

[John Thomas [:Johnt]]

Currently this issue ONLY occurs on the Flame 2.2
Result: vcf file appears twice within MMS message.

Environmental Variables:
Device: Flame 2.2 Kk Fullflash (319mb)
BuildID: 20151019032501
Gaia: 885647d92208fb67574ced44004ab2f29d23cb45
Gecko: 6b4e563acaf9
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

----------------------------

This issue is NOT occurring for Aries 2.5 and Flame 2.5
Result: User is taken to the contact information screen. 

Environmental Variables:
Device: Aries 2.5 Kk
BuildID: 20151019104907
Gaia: f75bd584aca0a751a5bed115800250faa8412927
Gecko: d3e87bb40753327550143ba8ac8ee27b300cd4a9
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 44.0a1 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Environmental Variables:
Device: Flame 2.5 Kk Fullflash (319mb)
BuildID: 20151019030208
Gaia: f75bd584aca0a751a5bed115800250faa8412927
Gecko: 1a157155a4fe0074b3d03b54fe9e466472c2cd56
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 44.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Comment 6

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Etienne this is easy to reproduce, but only on 2.2 branch.

Comment 7

[Etienne Segonzac (:etienne)]

(In reply to Jayme Mercado [:JMercado] from comment #6)
> Etienne this is easy to reproduce, but only on 2.2 branch.

Thanks! So it's fixed, closing :)