Closed
Bug 1183048
Opened 9 years ago
Closed 9 years ago
fix talos compare.py to include 'damp' test as well as use geometric mean vs average for results
Categories
(Testing :: Talos, defect)
Testing
Talos
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jmaher, Assigned: jmaher)
Details
Attachments
(1 file)
|
3.70 KB,
patch
|
parkouss
:
review+
|
Details | Diff | Splinter Review |
some minor cleanup to keep this updated and useful
|
Assignee | |
Comment 1•9 years ago
|
||
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8632724 [details] [diff] [review] compare_updates.patch So I can not test it right now, but this looks good to me. Assuming that you double checked or tested those values: > + dataid = 4 # 3 for average, 4 for geomean > + dataid = 7 # 3 for average, 7 for geomean (thanks for the comments BTW!) and that the values of the variables "average" and "geomean" in the same functions (parseGraphResultsByChangeset and parseGraphResultsByDate) still make sense, I would say we're all good!
Attachment #8632724 -
Flags: review?(j.parkouss) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
https://hg.mozilla.org/build/talos/rev/c7926eb14de8
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•