Fix typos and update out-of-date documentation of Layer and DisplayItem

RESOLVED FIXED in Firefox 42

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: TYLin, Assigned: TYLin)

Tracking

unspecified
mozilla42
Points:
---

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(5 attachments)

(Assignee)

Description

3 years ago
I found some typos and out-of-date documentation when I read Layer and DisplayItem code. I have some patches at hand.
(Assignee)

Comment 1

3 years ago
Created attachment 8632775 [details]
MozReview Request: Bug 1183085 - Correct the name for nsDisplayItem; r=roc

Bug 1183085 - Correct the name for nsDisplayItem; r=roc
Attachment #8632775 - Flags: review?(roc)
(Assignee)

Comment 2

3 years ago
Created attachment 8632776 [details]
MozReview Request: Bug 1183085 - Remove EndConstruction() from layer documentation; r=roc

Bug 1183085 - Remove EndConstruction() from layer documentation; r=roc

EndConstruction() was removed in bug 564993.
Attachment #8632776 - Flags: review?(roc)
(Assignee)

Comment 3

3 years ago
Created attachment 8632777 [details]
MozReview Request: Bug 1183085 - Correct argument name for BuildContainerLayerFor; r=roc

Bug 1183085 - Correct argument name for BuildContainerLayerFor; r=roc
Attachment #8632777 - Flags: review?(roc)
(Assignee)

Comment 4

3 years ago
Created attachment 8632778 [details]
MozReview Request: Bug 1183085 - Update description for nsDisplayList methods; r=roc

Bug 1183085 - Update description for nsDisplayList methods; r=roc

AppendNewToTop and AppendNewToBottom do not return
NS_ERROR_OUT_OF_MEMORY now.
Attachment #8632778 - Flags: review?(roc)
(Assignee)

Comment 5

3 years ago
Created attachment 8632779 [details]
MozReview Request: Bug 1183085 - Correct a typo in FrameLayerBuilder.h; r=roc

Bug 1183085 - Correct a typo in FrameLayerBuilder.h; r=roc
Attachment #8632779 - Flags: review?(roc)
Comment on attachment 8632775 [details]
MozReview Request: Bug 1183085 - Correct the name for nsDisplayItem; r=roc

https://reviewboard.mozilla.org/r/13125/#review11745

Ship It!
Attachment #8632775 - Flags: review?(roc) → review+
Comment on attachment 8632776 [details]
MozReview Request: Bug 1183085 - Remove EndConstruction() from layer documentation; r=roc

https://reviewboard.mozilla.org/r/13127/#review11747

Ship It!
Comment on attachment 8632777 [details]
MozReview Request: Bug 1183085 - Correct argument name for BuildContainerLayerFor; r=roc

https://reviewboard.mozilla.org/r/13129/#review11749

Ship It!
Attachment #8632777 - Flags: review?(roc) → review+
Comment on attachment 8632778 [details]
MozReview Request: Bug 1183085 - Update description for nsDisplayList methods; r=roc

https://reviewboard.mozilla.org/r/13131/#review11751

Ship It!
Comment on attachment 8632779 [details]
MozReview Request: Bug 1183085 - Correct a typo in FrameLayerBuilder.h; r=roc

https://reviewboard.mozilla.org/r/13133/#review11753

Ship It!
Attachment #8632779 - Flags: review?(roc) → review+
You need to log in before you can comment on or make changes to this bug.