1183085 - Fix typos and update out-of-date documentation of Layer and DisplayItem

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

I found some typos and out-of-date documentation when I read Layer and DisplayItem code. I have some patches at hand.

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: MozReview Request: Bug 1183085 - Correct the name for nsDisplayItem; r=roc

Bug 1183085 - Correct the name for nsDisplayItem; r=roc

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: MozReview Request: Bug 1183085 - Remove EndConstruction() from layer documentation; r=roc

Bug 1183085 - Remove EndConstruction() from layer documentation; r=roc

EndConstruction() was removed in bug 564993.

Comment 3

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: MozReview Request: Bug 1183085 - Correct argument name for BuildContainerLayerFor; r=roc

Bug 1183085 - Correct argument name for BuildContainerLayerFor; r=roc

Comment 4

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: MozReview Request: Bug 1183085 - Update description for nsDisplayList methods; r=roc

Bug 1183085 - Update description for nsDisplayList methods; r=roc

AppendNewToTop and AppendNewToBottom do not return
NS_ERROR_OUT_OF_MEMORY now.

Comment 5

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: MozReview Request: Bug 1183085 - Correct a typo in FrameLayerBuilder.h; r=roc

Bug 1183085 - Correct a typo in FrameLayerBuilder.h; r=roc

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8632775 [details]
MozReview Request: Bug 1183085 - Correct the name for nsDisplayItem; r=roc

https://reviewboard.mozilla.org/r/13125/#review11745

Ship It!

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8632776 [details]
MozReview Request: Bug 1183085 - Remove EndConstruction() from layer documentation; r=roc

https://reviewboard.mozilla.org/r/13127/#review11747

Ship It!

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8632777 [details]
MozReview Request: Bug 1183085 - Correct argument name for BuildContainerLayerFor; r=roc

https://reviewboard.mozilla.org/r/13129/#review11749

Ship It!

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8632778 [details]
MozReview Request: Bug 1183085 - Update description for nsDisplayList methods; r=roc

https://reviewboard.mozilla.org/r/13131/#review11751

Ship It!

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8632779 [details]
MozReview Request: Bug 1183085 - Correct a typo in FrameLayerBuilder.h; r=roc

https://reviewboard.mozilla.org/r/13133/#review11753

Ship It!

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/05bbc6899c5c
https://hg.mozilla.org/integration/mozilla-inbound/rev/36afd464a121
https://hg.mozilla.org/integration/mozilla-inbound/rev/2bfa6dfd1079
https://hg.mozilla.org/integration/mozilla-inbound/rev/2c4622a35bde
https://hg.mozilla.org/integration/mozilla-inbound/rev/e974d344bf02

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/05bbc6899c5c
https://hg.mozilla.org/mozilla-central/rev/36afd464a121
https://hg.mozilla.org/mozilla-central/rev/2bfa6dfd1079
https://hg.mozilla.org/mozilla-central/rev/2c4622a35bde
https://hg.mozilla.org/mozilla-central/rev/e974d344bf02