1183093 - Uninitialised value use in Probe::Trigger

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Julian Seward [:jseward]]

It appears that ProbeManager::ProbeManager does not give initial
values for mIsActive nor mInitialized.  This appears to lead to an
uninitialised use of mIsActive at xpcom/build/perfprobe.cpp:64.

Comment 1

[David Teller [:Yoric] - still alive but not very active]

Both `mIsActive` and `mInitialized` should be initialized to `false` in the constructor.

Comment 2

[Julian Seward [:jseward]]

Attachment: Errors reported by DrMemory on Windows 7

Comment 3

[Julian Seward [:jseward]]

Attachment: bug1183093-1.diff

A possible fix

Comment 4

[Julian Seward [:jseward]]

Yoric, what is the status on this now?  Is there a different patch available?

Comment 5

[David Teller [:Yoric] - still alive but not very active]

The contributor didn't upload his patch, so I'll review yours.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a9776258f778

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a9776258f778