make marionette --version flag also show the transport and driver package versions

RESOLVED FIXED in Firefox 42

Status

Testing
Marionette
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: parkouss, Assigned: parkouss)

Tracking

({ateam-marionette-runner})

Trunk
mozilla42
ateam-marionette-runner
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
See bug 902125 comment 4.
(Assignee)

Comment 1

2 years ago
More precisely bug 902125 comment 5 (ideally --version would report the versions of marionette-driver and marionette-transport as well).
(Assignee)

Updated

2 years ago
Assignee: nobody → j.parkouss
Status: NEW → ASSIGNED
(Assignee)

Updated

2 years ago
Summary: make marionette --version flag show the client and drivers package → make marionette --version flag also show the transport and driver package versions
(Assignee)

Comment 2

2 years ago
Created attachment 8633975 [details] [diff] [review]
1183157.patch

Example:

> $ marionette --version
> marionette 0.16 (using marionette-driver: 0.10, marionette-transport: 0.5)
Attachment #8633975 - Flags: review?(dburns)
(Assignee)

Comment 3

2 years ago
While I was looking at it, I found something strange:

> $ cat client/requirements.txt | grep marionette
> marionette-driver >= 0.8

> $ cat driver/requirements.txt | grep marionette
> marionette-transport == 0.5


> $ cat client/setup.py | grep name=
> setup(name='marionette_client',

> $ cat driver/setup.py | grep name=
> setup(name='marionette_driver',

> $ cat transport/setup.py | grep name=
> setup(name='marionette-transport',

So this seems inconsistent, sometimes we use "_" for the name, sometimes "-", and in dependencies this is always "-".

Though pip is not annoyed by that, it seems that "pip install marionette-client" and "pip install marionette_client" are roughly equivalent commands. (same thing for dependencies, so all works fine). Still I think we should update the name of client and driver package in the setup.py
files and use "-" to be consistent.

:jgriffin, :automatedtester
May I create a bug for that, or do you see any objection ?
(Assignee)

Comment 4

2 years ago
Ah, pypi does convert "_" to "-" automatically it seems:

http://stackoverflow.com/questions/16385099/why-does-pip-convert-underscores-to-dashes

This is probably because pep8 discourage the use of underscores in package names:

https://www.python.org/dev/peps/pep-0008/#package-and-module-names
I agree it would be good to change that for consistency if it doesn't break anything, and it sounds like it wouldn't.
Attachment #8633975 - Flags: review?(dburns) → review+
(Assignee)

Comment 6

2 years ago
Fixed conflicts due to mozlog update and pushed to try:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9ae2bc693a00
Keywords: ateam-marionette-runner
(Assignee)

Comment 7

2 years ago
Repushed to try because infra (or something issue):

https://treeherder.mozilla.org/#/jobs?repo=try&revision=80f1d2b073ed

All green now.

Comment 8

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/cb1ee8ad0f67
https://hg.mozilla.org/mozilla-central/rev/cb1ee8ad0f67
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox42: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Depends on: 1200409
You need to log in before you can comment on or make changes to this bug.