Closed
Bug 1183158
Opened 9 years ago
Closed 9 years ago
Remove the rest of EnumerateEntries calls from service worker code
Categories
(Core :: DOM: Service Workers, defect)
Core
DOM: Service Workers
Tracking
()
RESOLVED
FIXED
mozilla42
| Tracking | Status | |
|---|---|---|
| firefox42 | --- | fixed |
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(5 files)
|
2.93 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
|
3.24 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
|
2.98 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
|
2.58 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
|
2.57 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8632902 -
Flags: review?(amarchesini)
|
|
Assignee | |
Comment 2•9 years ago
|
||
Attachment #8632903 -
Flags: review?(amarchesini)
|
|
Assignee | |
Comment 3•9 years ago
|
||
Attachment #8632904 -
Flags: review?(amarchesini)
|
|
Assignee | |
Comment 4•9 years ago
|
||
Attachment #8632905 -
Flags: review?(amarchesini)
|
|
Assignee | |
Comment 5•9 years ago
|
||
Attachment #8632906 -
Flags: review?(amarchesini)
|
||
Updated•9 years ago
|
Attachment #8632902 -
Flags: review?(amarchesini) → review+
|
|
||
Updated•9 years ago
|
Attachment #8632903 -
Flags: review?(amarchesini) → review+
|
|
||
Updated•9 years ago
|
Attachment #8632904 -
Flags: review?(amarchesini) → review+
|
|
||
Updated•9 years ago
|
Attachment #8632905 -
Flags: review?(amarchesini) → review+
|
|
||
Updated•9 years ago
|
Attachment #8632906 -
Flags: review?(amarchesini) → review+
|
||
Comment 6•9 years ago
|
||
Comment on attachment 8632902 [details] [diff] [review] Part 1: Get rid of RegistrationEnumerator Review of attachment 8632902 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/workers/ServiceWorkerManagerService.cpp @@ +296,1 @@ > #endif Nit: no need for #ifdef DEBUG around a MOZ_ASSERT.
|
|
||
Comment 7•9 years ago
|
||
> Nit: no need for #ifdef DEBUG around a MOZ_ASSERT.
And ditto for the other four patches.
This bug really is a nice example of how much nicer iteration is than enumeration.|
|
||
Updated•9 years ago
|
Blocks: replace-nsTHashtable-Enumerate
https://hg.mozilla.org/integration/mozilla-inbound/rev/b0ea3f8b4512 https://hg.mozilla.org/integration/mozilla-inbound/rev/db9953b220ae https://hg.mozilla.org/integration/mozilla-inbound/rev/2e6a27e72d83 https://hg.mozilla.org/integration/mozilla-inbound/rev/5c7525b1e21c https://hg.mozilla.org/integration/mozilla-inbound/rev/2dad407995cc
|
||
Comment 9•9 years ago
|
||
Backed out for wpt failures. https://treeherder.mozilla.org/logviewer.html#?job_id=11636096&repo=mozilla-inbound https://hg.mozilla.org/integration/mozilla-inbound/rev/12534681927b
|
||
Comment 10•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/b37ee095e71f https://hg.mozilla.org/integration/mozilla-inbound/rev/96684d85aa76 https://hg.mozilla.org/integration/mozilla-inbound/rev/e090767bdd14 https://hg.mozilla.org/integration/mozilla-inbound/rev/fbc27d2d17f3 https://hg.mozilla.org/integration/mozilla-inbound/rev/150f2d5b21c0
|
||
Comment 11•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b37ee095e71f https://hg.mozilla.org/mozilla-central/rev/96684d85aa76 https://hg.mozilla.org/mozilla-central/rev/e090767bdd14 https://hg.mozilla.org/mozilla-central/rev/fbc27d2d17f3 https://hg.mozilla.org/mozilla-central/rev/150f2d5b21c0
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•