Date parse error in signature graph data

RESOLVED FIXED

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: peterbe, Assigned: thalia.e.chan)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
ISO8601Error: Unrecognised ISO 8601 date format: '=2015-07-01T00:00:00+00:00'

Stacktrace (most recent call last):

  File "django/core/handlers/base.py", line 112, in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "waffle/decorators.py", line 36, in _wrapped_view
    return view(request, *args, **kwargs)
  File "crashstats/crashstats/utils.py", line 53, in wrapper
    response = f(request, *args, **kw)
  File "crashstats/signature/views.py", line 328, in signature_graph_data
    d = isodate.parse_date(date.strip('>'))
  File "isodate/isodates.py", line 192, in parse_date
    raise ISO8601Error('Unrecognised ISO 8601 date format: %r' % datestring)
(Reporter)

Comment 1

3 years ago
Problem is here: https://github.com/mozilla/socorro/blob/master/webapp-django/crashstats/signature/views.py#L327

The date value does start with `>` but it actually starts with `>=`.

I can't git blame that line of code because of a revert-rebort mess in git but I suspect this is your territory Adrian.
Assignee: nobody → adrian
(Reporter)

Comment 2

3 years ago
Created attachment 8632921 [details] [diff] [review]
1183179.diff

This patch would solve the problem. I've tested it locally.

But the whole view completely lacks tests so I didn't want to write a whole new test for a view I don't understand fully just to fix this one thing.
This is actually Tchanders' territory. :)

Thalia, can you take a look at this problem? Also, I have been a bad reviewer and didn't notice that there were no unit tests. Could you please add some while you're at it?
Assignee: adrian → thalia.e.chan
(Reporter)

Comment 4

3 years ago
Hi Thalia, 
With regards to adding unit tests, feel free to file yourself a brand new bug specifically for adding the missing tests. I find that easier to compartmentalize than to have to re-open resolved bugs.
(Assignee)

Comment 5

3 years ago
Oops, yes that's my mistake. Thanks for the patch, will do this and make a new bug for the tests too.

Comment 6

3 years ago
Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/5f31c2be049e657f380f0bc8f118cba764250de2
Fixes Bug 1183179 - Date parse error in signature graph data

https://github.com/mozilla/socorro/commit/64b3c624a33d7faf4bd1b1cb7dfe2eb6657042fe
Merge pull request #2902 from Tchanders/signature-parse-dates

Fixes Bug 1183179 - Date parse error in signature graph data

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.