Aspect ratio of favicon is incorrect on standalone client

RESOLVED FIXED in Firefox 41

Status

Hello (Loop)
Client
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: abr, Assigned: standard8)

Tracking

unspecified
mozilla42
Points:
1

Firefox Tracking Flags

(firefox41 fixed, firefox42 fixed)

Details

Attachments

(2 attachments)

(Reporter)

Description

3 years ago
Created attachment 8632885 [details]
favicon-smash.png

When a link-clicker joins a room that has context, the favicon is rendered too narrow for its height. This issue appears to be more pronounced on Chrome than it is on Firefox.

See attached screenshot.
(Assignee)

Comment 1

3 years ago
Created attachment 8636540 [details] [diff] [review]
Aspect ratio of favicon in room context is sometimes wrong on the Loop standalone client.

The issue is we've got some shrink flex in there, and I think we really don't want to flex the size.
Attachment #8636540 - Flags: review?(mdeboer)
Comment on attachment 8636540 [details] [diff] [review]
Aspect ratio of favicon in room context is sometimes wrong on the Loop standalone client.

Review of attachment 8636540 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, thanks!
Attachment #8636540 - Flags: review?(mdeboer) → review+
Assignee: nobody → standard8
Status: NEW → ASSIGNED
Iteration: --- → 42.2 - Jul 27
Points: --- → 1
https://hg.mozilla.org/mozilla-central/rev/8e6bdb5af306
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
(Assignee)

Comment 5

3 years ago
Comment on attachment 8636540 [details] [diff] [review]
Aspect ratio of favicon in room context is sometimes wrong on the Loop standalone client.

Approval Request Comment
[Feature/regressing bug #]: Context for conversations
[User impact if declined]: If a website has a long word with no breaks in its name, then the Hello panel could display the favicon badly. This would also affect the display of context in the conversation window on aurora.
[Describe test coverage new/current, TreeHerder]: N/A css only
[Risks and why]: Low, minor css change.
[String/UUID change made/needed]: None
Attachment #8636540 - Flags: approval-mozilla-aurora?

Comment 6

3 years ago
Comment on attachment 8636540 [details] [diff] [review]
Aspect ratio of favicon in room context is sometimes wrong on the Loop standalone client.

CSS and one-line fix only. Let's uplift to Aurora.
Attachment #8636540 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Updated

3 years ago
status-firefox41: --- → affected
Flags: qe-verify+
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.