Closed
Bug 1183191
Opened 9 years ago
Closed 9 years ago
Frequent Source-invisible.js | Assertion failure: isNative(), at jsfun.h:460 (code -2147483645, args "--baseline-eager --no-fpu")
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla42
Tracking | Status | |
---|---|---|
firefox40 | --- | unaffected |
firefox41 | --- | fixed |
firefox42 | --- | fixed |
firefox-esr31 | --- | unaffected |
firefox-esr38 | --- | unaffected |
People
(Reporter: RyanVM, Assigned: jandem)
References
Details
(Keywords: assertion, crash, intermittent-failure)
Attachments
(3 files)
2.02 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
3.63 KB,
patch
|
shu
:
review+
|
Details | Diff | Splinter Review |
4.84 KB,
patch
|
jandem
:
review+
ritu
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
TEST-PASS | js\src\jit-test\tests\debug\Source-invisible.js | Success (code 0, args "--ion-eager --ion-offthread-compile=off --non-writable-jitcode --ion-check-range-analysis --ion-extra-checks --no-sse3 --no-threads") Assertion failure: isNative(), at c:\builds\moz2_slave\m-in_w32-d_sm-compacting-00000\src\js\src\jsfun.h:460 Exit code: -2147483645 FAIL - debug\Source-invisible.js TEST-UNEXPECTED-FAIL | js\src\jit-test\tests\debug\Source-invisible.js | Assertion failure: isNative(), at c:\builds\moz2_slave\m-in_w32-d_sm-compacting-00000\src\js\src\jsfun.h:460 (code -2147483645, args "--baseline-eager --no-fpu") INFO exit-status : -2147483645 INFO timed-out : False INFO stderr 2> Assertion failure: isNative(), at c:\builds\moz2_slave\m-in_w32-d_sm-compacting-00000\src\js\src\jsfun.h:460
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Comment 3•9 years ago
|
||
Reviewed by shu on IRC.
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Comment 10•9 years ago
|
||
Shu, I missed the comment warning about the self-hosting compartment... This patch fixes AutoDelazify to handle this case, it should fix the other intermittent I introduced.
Attachment #8633008 -
Flags: review?(shu)
Comment 11•9 years ago
|
||
Comment on attachment 8633008 [details] [diff] [review] Followup patch Review of attachment 8633008 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for the fix! Sorry I missed this too, too many things to remember. :(
Attachment #8633008 -
Flags: review?(shu) → review+
https://hg.mozilla.org/mozilla-central/rev/efcc25c8a97f https://hg.mozilla.org/mozilla-central/rev/52aa8c3dff26
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Reporter | ||
Comment 14•9 years ago
|
||
Please request Aurora approval on these whenever you're comfortable doing so :)
Flags: needinfo?(jdemooij)
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Comment 17•9 years ago
|
||
Landed a trivial follow-up patch to always null script_ in dropScript: https://hg.mozilla.org/integration/mozilla-inbound/rev/2b28e41cc6a3 It probably doesn't matter atm but it seemed a bit nicer. Will post a combined patch for Aurora.
Assignee | ||
Comment 18•9 years ago
|
||
Approval Request Comment [Feature/regressing bug #]: Bug 1165486. [User impact if declined]: Crashes. Fixes a frequent orange on Treeherder. [Describe test coverage new/current, TreeHerder]: On inbound. [Risks and why]: Low risk. [String/UUID change made/needed]: None.
Flags: needinfo?(jdemooij)
Attachment #8633384 -
Flags: review+
Attachment #8633384 -
Flags: approval-mozilla-aurora?
Comment on attachment 8633384 [details] [diff] [review] Patch for Aurora Approving for uplift as this has been in m-c for about a week now and also fixes an intermittent test failure.
Attachment #8633384 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Reporter | ||
Comment 21•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/3b0c7e2563c1
You need to log in
before you can comment on or make changes to this bug.
Description
•