1183243 - django_admin_log table is still used in the /admin tools

Status: VERIFIED FIXED

(Marketplace Graveyard :: Admin Tools, defect)

Description

[Andrew Williamson [:eviljeff]]

https://github.com/mozilla/zamboni/commit/c42e4b7fc2ed4f11547c7be49d3cbf97a135b53f removed the django_admin_log table but its still used for functionality in https://marketplace-dev.allizom.org/admin/models/access/group/50000/ and so on.

http://sentry.dmz.phx1.mozilla.com/marketplace-dev/marketplace-dev/group/28328/ is a sample traceback.

Fix would either be to:
- re-create the table on -dev (and patch the migration before it hits prod) (and stage?).
- or remove the relevant logging function in /admin (no-one looks at it)

Comment 1

[Allen Short [:ashort]]

migration fixed.
https://github.com/mozilla/zamboni/commit/c42e4b7fc2ed4f11547c7be49d3cbf97a135b53f

Comment 2

[Allen Short [:ashort]]

wrong link: migration fixed here --
https://github.com/mozilla/zamboni/commit/96159d38ccd772bf864c4405e281a3e83eb032c3

Comment 3

[krupa raj[:krupa]]

https://marketplace-dev.allizom.org/admin/models/access/group/50000/ works fine now and there are no tracebacks.

Comment 4

[Andrew Williamson [:eviljeff]]

just loading https://marketplace-dev.allizom.org/admin/models/access/group/50000/ wasn't actually the traceback - you either needed to make a change to the page and submit, or access the history https://marketplace-dev.allizom.org/admin/models/access/group/50000/history/ (which does still 500)

Comment 5

[Allen Short [:ashort]]

Looks like this never should have worked.

https://github.com/mozilla/zamboni/commit/28d3245197a8334a7185756336fdb6e44c846769

Does it work on prod?

Comment 6

[Andrew Williamson [:eviljeff]]

(In reply to Allen Short [:ashort] from comment #5)
> Looks like this never should have worked.
> 
> https://github.com/mozilla/zamboni/commit/
> 28d3245197a8334a7185756336fdb6e44c846769
> 
> Does it work on prod?

Hmm, I guess the history link didn't (I'm sure it must have at one point).  The form submission did though.

Comment 7

[krupa raj[:krupa]]

(In reply to Andrew Williamson [:eviljeff] from comment #4)
> just loading
> https://marketplace-dev.allizom.org/admin/models/access/group/50000/ wasn't
> actually the traceback - you either needed to make a change to the page and
> submit, or access the history
> https://marketplace-dev.allizom.org/admin/models/access/group/50000/history/
> (which does still 500)

I actually removed amy and added her back and it didn't traceback.

Comment 8

[krupa raj[:krupa]]

https://marketplace-dev.allizom.org/admin/models/access/group/50000/history/ doesn't traceback and adding a new user doesn't cause any traceback at https://marketplace-dev.allizom.org/admin/models/access/group/50000/