Remember Password prompt does not work on Twitch

RESOLVED FIXED

Status

()

Firefox for iOS
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: aaronmt, Assigned: bnicholson)

Tracking

({reproducible})

unspecified
ARM
iOS
reproducible

Firefox Tracking Flags

(fxios1.1+, fxios-v1.1 fixed, fxios-v1.0.5 wontfix)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

2 years ago
Currently there is no remember password prompt on Twitch.

Visit http://twitch.tv, sign-in, no dialog
(Reporter)

Comment 1

2 years ago
This is mentioned on Build #24 on ios-feedback

https://groups.google.com/a/mozilla.com/d/msgid/ios-feedback/CA%2B7ao4wuPbE63LL7CzmfrG%3DV0w-3qzA6FZ%3DJW9mibPYHT5eVpQ%40mail.gmail.com?utm_medium=email&utm_source=footer
(Reporter)

Updated

2 years ago
Keywords: reproducible
Wes, could you investigate?
Assignee: nobody → wjohnston
Status: NEW → ASSIGNED
tracking-fxios: ? → 1.1+
This login is in an iframe. We intentionally don't inject the logins script in iframes yet, to avoid security issues there. We could though... I think?
Created attachment 8641298 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/837
Attachment #8641298 - Flags: review?(rnewman)
Comment on attachment 8641298 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/837

This looks good to me, but I think it needs multiple sets of eyes.
Attachment #8641298 - Flags: review?(bnicholson)
(Assignee)

Comment 6

2 years ago
Comment on attachment 8641298 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/837

I'm not too familiar with our passwords-message-passing mechanism, but this is fine with me if it works. We can do a more thorough security review as part of bug 1172091.
Attachment #8641298 - Flags: review?(bnicholson) → review+
Attachment #8641298 - Flags: review?(rnewman) → review+
(Assignee)

Comment 7

2 years ago
Created attachment 8644106 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/871

Will land in v1.1.
Assignee: wjohnston2000 → bnicholson
Attachment #8641298 - Attachment is obsolete: true
Attachment #8644106 - Flags: review+
(Reporter)

Updated

2 years ago
See Also: → bug 1195764
Blocks: 1157737
(Reporter)

Comment 8

2 years ago
Tried applying on master locally but there's conflicts
Flags: needinfo?(bnicholson)
Oops forgot to add a comment - looks like we can merge this after a rebase/Swift 2.0 update?
(Assignee)

Comment 10

2 years ago
Updated and merged.

https://github.com/mozilla/firefox-ios/commit/1844b83c55a2e182f0fabde5e8a32963677d61cd
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-fxios-v1.0.5: --- → wontfix
status-fxios-v1.1: --- → fixed
Resolution: --- → FIXED
(Assignee)

Updated

2 years ago
Flags: needinfo?(bnicholson)
(Reporter)

Updated

2 years ago
See Also: → bug 1236636
(Reporter)

Updated

2 years ago
See Also: → bug 1238098
You need to log in before you can comment on or make changes to this bug.