1183273 - Solaris 10 Build Poison.cpp & nsZipArchive.cpp fail to compile: madvise

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[testers1717]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Firefox/31.0
Build ID: 20150624141335

Steps to reproduce:

Attempt to Build Firefox 31 ESR on Solaris 10 with gcc 4.9.2
(I'm using pkgsrc to make this process less difficult and manual)

(Note that Solaris 10 is significantly different than Solaris 11 in the libraries that it normally provides. The hack for Solaris 11 is to use the os provided posix_madvise c++ wrapper which works. My problem is specifically with Solaris 10!)


Actual results:

Build fails because it can't compile the following files: 

mozilla-esr31/mfbt/Poison.cpp
mozilla-esr31/modules/libjar/nsZipArchive.cpp

Build Log:
g++ -o Poison.o -c  -I../dist/system_wrappers -include /usr/pkgsrc/www/firefox31/work/mozilla-esr31/config/gcc_hidden.h -DIMPL_MFBT -DMOZ_GLUE_IN_PROGRAM -DNO_NSPR_10_SUPPORT -I/usr/pkgsrc/www/firefox31/work/mozilla-esr31/mfbt -I.  -I../dist/include  -I/usr/pkg/include/nspr -I/usr/pkg/include/nss/nss -I/usr/pkg/include/nss -I/usr/pkg/include/nspr   -I/usr/pkgsrc/www/firefox31/work/build/dist/include  -I/usr/pkg/include/pixman-1    -fPIC  -DPNG_NO_ASSEMBLER_CODE -I/usr/include -I/usr/pkg/include -I/usr/pkg/include/nspr -I/usr/pkg/include/nss/nss -I/usr/pkg/include/libdrm -I/usr/pkg/include/freetype2 -DMOZILLA_CLIENT -include ../mozilla-config.h -MD -MP -MF .deps/Poison.o.pp -DPNG_NO_ASSEMBLER_CODE -I/usr/include -I/usr/pkg/include -I/usr/pkg/include/nspr -I/usr/pkg/include/nss/nss -I/usr/pkg/include/libdrm -I/usr/pkg/include/freetype2 -O2 -I/usr/include -I/usr/pkg/include -I/usr/pkg/include/nspr -I/usr/pkg/include/nss/nss -I/usr/pkg/include/libdrm -I/usr/pkg/include/freetype2 -fno-exceptions -fno-strict-aliasing -fno-rtti -fno-exceptions -fno-math-errno -std=gnu++0x -pthread -pipe  -DNDEBUG -DTRIMMED -O2 -fomit-frame-pointer     /usr/pkgsrc/www/firefox31/work/mozilla-esr31/mfbt/Poison.cpp
/usr/pkgsrc/www/firefox31/work/mozilla-esr31/mfbt/Poison.cpp: In function 'bool ProbeRegion(uintptr_t, uintptr_t)':
/usr/pkgsrc/www/firefox31/work/mozilla-esr31/mfbt/Poison.cpp:128:65: error: 'madvise' was not declared in this scope
   if (madvise(reinterpret_cast<void*>(region), size, MADV_NORMAL)) {
                                                                 ^
gmake[3]: *** [Poison.o] Error 1
gmake[3]: Leaving directory `/usr/pkgsrc/www/firefox31/work/build/mfbt'


Applying a workaround that I've seen in forums by declaring the function an external "C" function causes link errors later on.
//This is what I added
#ifdef SOLARIS
extern "C" int madvise(void *addr, size_t len, int behav);
#endif /* sun || __sun */

//This is the link error:
Undefined                       first referenced
 symbol                             in file
_madvise                            ../../../dist/lib/libmozglue.a(Poison.o)  (symbol scope specifies local binding)
ld: fatal: symbol referencing errors. No output written to js
collect2: error: ld returned 1 exit status
gmake[3]: *** [js] Error 1
gmake[3]: Leaving directory `/usr/pkgsrc/www/firefox31/work/build/js/src/shell'



Expected results:

Solaris 10 should be able to compile Poison.cpp and nsZipArchive.cpp using gcc 4.9.2

Comment 1

[Petr Sumbera]

Attachment: Bug1183273.patch

Poison.cpp part was already addressed via Bug 1158445.

Comment 2

[Petr Sumbera]

Can you please do the checkin work too? Thank you!

Comment 3

[Nathan Froyd [:froydnj]]

(In reply to Petr Sumbera from comment #2)
> Can you please do the checkin work too? Thank you!

Sure, can do.  Thanks for the patch!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/be6c6b7127ca
posix_madvise() should be used instead of madvise on Solaris; r=froydnj

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/be6c6b7127ca