1183278 - Too easy to add more than 5 series in graphs UI

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect)

Description

[William Lachance (:wlach)]

Attachment: Graphserver warning dialog when trying to add more than 6

Currently it's very easy to select many (> 5) series, which doesn't work that well in perfherder (we don't match colors for them, for example).

I think we should warn the user that this won't work very well, like graphserver currently does (see screenshot). Let's do the calculation based not only on the number the user wants to add, but also the number currently in the graph.

i.e. when the user presses "Add tests" in the test chooser, check if the # of tests to add + # of tests currently part of the graph > 5. If so, then pop up a dialog asking them to confirm that they want to add this many tests (use the same wording as the graph server dialog)

:jmaher, does this make sense? Anything you'd have to add? Assigning to :MikeLing assuming it does.

Comment 1

[MikeLing]

I'm happy to work on this:)

Comment 2

[MikeLing]

Attachment: confirm dialog for Bug 1183278.png

I found the confirm dialog is quite different with the patch you show me. And I don't know how to custom it(actually, I found I can't after I google it). Could you give me some advices about it? Thank you!

Comment 3

[William Lachance (:wlach)]

Comment on attachment 8633926 [details]
confirm dialog for Bug 1183278.png

This looks fine to me. Some of the english grammar is wrong. "load more" should be "loading more" Just use the same text as the graphserver one and you should be fine. :)

http://hg.mozilla.org/graphs/file/0902640f40ba/js/common.js#l335

Confirm is quite easy to use: you just synchronously call it and grab its return value.

https://developer.mozilla.org/en-US/docs/Web/API/Window/confirm

Comment 4

[MikeLing]

Attachment: PR for bug 1183278

Comment 5

[William Lachance (:wlach)]

Comment on attachment 8634521 [details]
PR for bug 1183278

More or less good, some minor things I'd like to see changed before this goes in.

Comment 6

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/b34690490a106efececd72dda9c9ecf2014f0b41
Bug 1183278 - Too easy to add more than 5 series in graphs UI

Comment 7

[William Lachance (:wlach)]

Thanks!