1183356 - Muting functionality is broken after the audio channel rewrite

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[(no longer active)]

I will need to investigate why.

Comment 1

[(no longer active)]

Looks like AudioChannelAgent has switched in bug 1113086 to be tied to the outer window, while some of the code surrounding is assuming inner windows.

Comment 2

[(no longer active)]

Attachment: Part 1: Use the outer window when refreshing media elements

Comment 3

[(no longer active)]

Attachment: Part 2: Add assertions enforcing the usage of outer windows for all of the entry points of the API

The assertions here serve as a unit test for the previous commit,
because with these, our existing tests would have caught this bug.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Hmm, and we really want to use outer window?  We don't end up leaking any behavior between page loads?

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/da4985b5cbef
https://hg.mozilla.org/integration/mozilla-inbound/rev/dc97f665d047

Comment 6

[Carsten Book [:Tomcat]]

backed out for assertion failures like https://treeherder.mozilla.org/logviewer.html#?job_id=11657715&repo=mozilla-inbound

Comment 7

[(no longer active)]

(In reply to Olli Pettay [:smaug] from comment #4)
> Hmm, and we really want to use outer window?  We don't end up leaking any
> behavior between page loads?

We do wait to retain the behavior.  For example, if you mute a tab, you don't want it to play audio on the next navigation.

Comment 8

[Pulsebot]

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/876c6b5cefa3
https://hg.mozilla.org/integration/mozilla-inbound/rev/ecafd2d2a1f1

Comment 9

[(no longer active)]

Attachment: Part 2: Add assertions enforcing the usage of outer windows for all of the entry points of the API

The assertions here serve as a unit test for the previous commit,
because with these, our existing tests would have caught this bug.

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b394e9310540
https://hg.mozilla.org/integration/mozilla-inbound/rev/53ffaa2b1ce2

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b394e9310540
https://hg.mozilla.org/mozilla-central/rev/53ffaa2b1ce2