Closed Bug 1183356 Opened 5 years ago Closed 5 years ago

Muting functionality is broken after the audio channel rewrite

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file, 2 obsolete files)

I will need to investigate why.
Looks like AudioChannelAgent has switched in bug 1113086 to be tied to the outer window, while some of the code surrounding is assuming inner windows.
Attachment #8633244 - Flags: review?(amarchesini)
The assertions here serve as a unit test for the previous commit,
because with these, our existing tests would have caught this bug.
Attachment #8633245 - Flags: review?(amarchesini)
Depends on: 1183446
Attachment #8633244 - Flags: review?(amarchesini) → review+
Attachment #8633245 - Flags: review?(amarchesini) → review+
Hmm, and we really want to use outer window?  We don't end up leaking any behavior between page loads?
backed out for assertion failures like https://treeherder.mozilla.org/logviewer.html#?job_id=11657715&repo=mozilla-inbound
Flags: needinfo?(ehsan)
(In reply to Olli Pettay [:smaug] from comment #4)
> Hmm, and we really want to use outer window?  We don't end up leaking any
> behavior between page loads?

We do wait to retain the behavior.  For example, if you mute a tab, you don't want it to play audio on the next navigation.
Flags: needinfo?(ehsan)
The assertions here serve as a unit test for the previous commit,
because with these, our existing tests would have caught this bug.
Attachment #8633244 - Attachment is obsolete: true
Attachment #8633245 - Attachment is obsolete: true
Attachment #8633524 - Flags: review?(amarchesini)
Attachment #8633524 - Flags: review?(amarchesini) → review+
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.