1183408 - Various security tests failing due to wrong icon references

Status: RESOLVED FIXED

(Testing :: Firefox UI Tests, defect)

Description

[Chris Manchester (limited bugmail, email directly)]

I noticed travis started failing on a few of the security tests. Bug 1175678 invalidated some of the icon checks.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Given that no-one was working on a fix for it, I will take this bug.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

test_dv_certificate.py:
AssertionError: 'identity-icons-https' not found in u'url("chrome://browser/skin/identity-secure.svg")'

test_ev_certificate.py:
AssertionError: 'identity-icons-https' not found in u'url("chrome://browser/skin/identity-secure.svg")'

test_mixed_content_page.py:
AssertionError: False is not true (favicon.value_of_css_property('list-style-image'))

test_mixed_script_content_blocking.py:
TimeoutException: Timed out after 5.0 seconds with message: The correct icon is displayed

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

All those failures seem to be the result of the icon changes in bug 1175678.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: github_pull_request.txt

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8643819 [details] [review]
github_pull_request.txt

doing a drive by as per irc request- a fairly straightforward change- ideally in the future developers will be able to catch this on their own :)

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Thanks Joel. So the stalled travis build is strange but I do not see how this can be related to this patch. It's in a totally different area. If it turns out to be permanent, I will file a new bug for it. But locally all works fine. So it could be related to XVFB.

Merged the PR as:
https://github.com/mozilla/firefox-ui-tests/commit/4b6ce1e1aa25d06cb0942032d74ff1b2856b1bbb

It might be that this patch will be necessary for 41.0, but it's not clear yet if the change will be backported.