Links from attachments to mozreview or github requests should show a [review] link which takes you to the attached url

NEW
Unassigned

Status

()

bugzilla.mozilla.org
Extensions: BMO
3 years ago
3 years ago

People

(Reporter: glandium, Unassigned)

Tracking

Production

Details

(Reporter)

Description

3 years ago
Here is how I go through my review queue:
- I open the "My requests" page on bmo
- I go through the list of feedback, needinfo and review requests and for each of those that I want to do at that moment, I use the attachment link.

For pure bugzilla attachments, clicking gets me to the patch content (the raw attachment), or, when clicking on [review], gets me to splinter.

For mozreview attachments, there is no [review] link, and clicking gets me to https://reviewboard.mozilla.org/r/id, not https://reviewboard.mozilla.org/r/id/diff/, which means I'm still one click and one page load away from reviewing.

Relatedly, for github PR fake attachments, that also sends to the PR, not the diff view. I guess I should file a separate bug for that?

Comment 1

3 years ago
Hm yeah, I'm addressing the lack of diff link in the MozReview table in bug 1123143, but having the attachment link itself go to the diff probably makes sense.  Or maybe we should finally get external code-review-tool links closer to being first-class citizens of Bugzilla, with [review] links and such.  I'll bring that up with the BMO devs.
Component: Extensions: MozReview Integration → Extensions: BMO
Summary: Links from attachments to mozreview requests should probably open the diff → Links from attachments to mozreview or github requests should show a [review] link which takes you to the attached url
See Also: → bug 1146780
You need to log in before you can comment on or make changes to this bug.