Several assertions escaped full conversion to logical coordinates

RESOLVED FIXED in Firefox 42

Status

()

defect
--
trivial
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jruderman, Assigned: jfkthame)

Tracking

Trunk
mozilla42
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(1 attachment)

In rev e0145b66ac03, four assertions were partially converted to logical coordinates: the conditions were updated, but the text was not.

https://hg.mozilla.org/mozilla-central/rev/e0145b66ac03#l12.1139 (2 assertions)

https://hg.mozilla.org/mozilla-central/rev/e0145b66ac03#l12.1447 (2 assertions)
(I noticed this because of bug 481089.)
Yup, we need to update these assertion texts that were overlooked. I also tweaked a couple of nearby comments that caught my eye.
Attachment #8633355 - Flags: review?(dholbert)
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Comment on attachment 8633355 [details] [diff] [review]
Update the wording of a few assertions to reflect logical-coordinate conversion

Thanks!
Attachment #8633355 - Flags: review?(dholbert) → review+
url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/d6cec98744a6569ffadcc7c3492212789f894a51
changeset:  d6cec98744a6569ffadcc7c3492212789f894a51
user:       Jonathan Kew <jkew@mozilla.com>
date:       Thu Jul 16 10:08:10 2015 +0100
description:
Bug 1183439 - Update the wording of a few assertions to reflect logical-coordinate conversion. r=dholbert
https://hg.mozilla.org/mozilla-central/rev/d6cec98744a6
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.